Command to delete grids that fail an IsWorking check for a specified block. #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from essentials master
LordTylus
suggested changes
Aug 6, 2020
| @@ -59,6 +59,30 @@ public void Delete() | |||
| Log.Info($"Cleanup deleted {count} grids matching conditions {string.Join(", ", Context.Args)}"); | |||
| } | |||
|
|
|||
| [Command("delete offtype", "Deletes grids with specified blocks toggled off.")] | |||
There was a problem hiding this comment.
Why is this a separate command tho?
I personally prefer it to keep it as !cleanup list or !cleanup delete
Instead you could have added a new condition you can see how for example HasType is implemented in line 385
As it is implemented now I have not the ability to just "list" which grids would be affected. And since I cannot see what would be affected I cannot check if my filter is correct or I for example need to exclude something with other conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 911b610 is just updating my fork to the current TorchAPI/Essentials master.
Commit 6aafed3 adds a "delete offtype" command to "!cleanup" to delete grids based on whether a specified blocktype is non-functional
isWorking == falseCode originally written by Teknikal (AdamOckley), he just asked me to put in a clean pull request for it for him.