Skip to content

Commit

Permalink
fix: default timeout was originally at 60s,
Browse files Browse the repository at this point in the history
but for each ftp-client it was defined at 3s,
Setting it to 10s is too small when we have a long list of files that could takes too much time to resolve,
the value should be increased, in this commit, am tripling the default fomr FTPS class that was at 60s to 180s.

Later on, we should find a way to set a FF that will forward that
extremly HUGE value to the lib itself.
  • Loading branch information
Sanix-Darker committed Oct 13, 2023
1 parent d8118be commit eac79a3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion peakina/io/ftp/ftp_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import paramiko

FTP_SCHEMES = ["ftp", "ftps", "sftp"]
_DEFAULT_MAX_TIMEOUT_SECONDS = 10
_DEFAULT_MAX_TIMEOUT_SECONDS = 180
_DEFAULT_MAX_RETRY = 7

FTPClient = ftplib.FTP | paramiko.SFTPClient
Expand Down

0 comments on commit eac79a3

Please sign in to comment.