Option for start command to also reset #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
See how Torje here cannot automatically reset their timer whilst AutoSplit isn't running: https://youtu.be/Tt0llYwGFgw
After carefully looking at it, it seems everything is working as intended in AutoSplit:
On LiveSplit's side:
Doc: https://github.com/LiveSplit/LiveSplit.AutoSplitters/blob/master/README.md#automatic-timer-start-1
And confirmed by looking at the source https://github.com/LiveSplit/LiveSplit/blob/4d30d15ec62e3bb24910b0944949fb55265f3884/LiveSplit/LiveSplit.Core/Model/TimerModel.cs#L37-L53
Potential solutions
So it seems that what we need is either:
Here I'm going for the second solution which is immediately actionable, and making it an option as it may not always be desirable. The first solution would be better long term but is dependant on #219