Update to 1.20.4 #155
Open
Update to 1.20.4 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kground methods - Added additional required parameters to onMouseScroll() The following seems to be handled by the game, and are no longer required: - Commented out containerTick() - Commented out onTick() - Commented out renderBackground()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated JEC to 1.20.4
Replaced deprecated methods, and added new required parameters.
From what I could find with testing,
containerTick(),onTick()andrenderBg()are no longer required.The handling of the blinking cursor seems to now be handled internally within the game, along with the application of the tinted background.
renderBg()is now an empty method. Completely removing this method requires changing theJecaGuiclass' declaration(?) which I am not familiar enough with at this time. Whether the method is essential or not is unknown to me, as testing showed this function was called several times. Visually comparing to1.20.1and1.20.4yielded no conclusive answer.Issues / Notes:
runClientwith Forge fails on load. Build seems to function when tested manually. Seems to be Architechtury issue?1.20.1. Developers stated a1.20.4release is coming soon.Either a new branch should be made for
1.20.4or1.20.1should be replaced.