fix: only show active items and variants

ToxicToast · Aug 26, 2024 · b33e2a4 · b33e2a4
1 parent 2a7c9f3
commit b33e2a4
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/apps/cronjob-service/src/app/cronjob/shoppinglist.service.ts b/apps/cronjob-service/src/app/cronjob/shoppinglist.service.ts
@@ -31,13 +31,16 @@ export class ShoppingListService {
 
 	private async getItemsWithStockAlert(): Promise<Array<ItemDAO>> {
 		const items = await this.getAllItems();
-		return items.filter((item) => item.isStockAlert);
+		return items.filter(
+			(item: ItemDAO) => item.isStockAlert && item.isActive,
+		);
 	}
 
 	private async getItemVariants(item_id): Promise<Array<ItemVariantDAO>> {
-		return await this.itemVariantClient
+		const variants = await this.itemVariantClient
 			.send(FoodfolioProductVariantTopics.ITEMID, { item_id })
 			.toPromise();
+		return variants.filter((variant: ItemVariantDAO) => variant.isActive);
 	}
 
 	async createShoppingListItem(