Smooth out hue transitions. #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In spite of the API taking uint16_t for the HSV parameters for hsv() (which appears to be in order to retain compatibility with existing plugins), the expected values are actually in the 0 ... 255 range. Update calls to make sure values passed are within that range. This did mean flattening out the value portion from 128 ... 255 to a flat 255, which isn't ideal, but I didn't have a better idea off the top of my head. The effect of this change is that there are no longer oddly flashing colors while cycling through the ripple effect. In addition I've added a starting_hue constant (set to a shade of purple I like, but easily changed), and a compile time #ifdef that controls whether or not to cycle hues, called CONSTANT_HUE. Personally, I prefer the CONSTANT_HUE effect, which is less blingy, but IMHO shows the ripple effect better. This should probably be turned into a run time switch.
obra
pushed a commit
to keyboardio/Kaleidoscope
that referenced
this pull request
Dec 20, 2018
Based largely on ToyKeeper/Kaleidoscope-LED-Wavepool#8, this smooths out the hue transitions, so that the ripple is a nice rainbow, without oddly flashing colors while cycling through the effect. Thanks @bjc for the change! Signed-off-by: Gergely Nagy <[email protected]>
obra
pushed a commit
to keyboardio/Kaleidoscope
that referenced
this pull request
Dec 20, 2018
While the rainbow colors are great, some may want to restrict the colors to a single hue. For this purpose, the `ripple_hue` property was introduced. It defaults to `Wavepool.rainbow_hue` (a special value that tells the plugin to use multiple hues). Inspired by @bjc's ToyKeeper/Kaleidoscope-LED-Wavepool#8. Signed-off-by: Gergely Nagy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In spite of the API taking uint16_t for the HSV parameters for hsv()
(which appears to be in order to retain compatibility with existing
plugins), the expected values are actually in the 0 ... 255 range.
Update calls to make sure values passed are within that range. This
did mean flattening out the value portion from 128 ... 255 to a flat
255, which isn't ideal, but I didn't have a better idea off the top of
my head.
The effect of this change is that there are no longer oddly flashing
colors while cycling through the ripple effect.
In addition I've added a starting_hue constant (set to a shade of
purple I like, but easily changed), and a compile time #ifdef that
controls whether or not to cycle hues, called
CONSTANT_HUE. Personally, I prefer the CONSTANT_HUE effect, which is
less blingy, but IMHO shows the ripple effect better. This should
probably be turned into a run time switch.