Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add deprecated field to RegistryAction #751

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: Add deprecated field to RegistryAction #751

wants to merge 16 commits into from
+101 −0

Conversation

topher-lo
Copy link
Contributor

@topher-lo topher-lo commented Jan 15, 2025 •
edited
Loading

What changed

  • Add optional deprecated field to mark the RegistryAction as deprecated along with a message

QA

  • Add deprecated field to a template and synced
  • Added a deprecated function to the test module fixture in test_registry
  • Added test that deprecated function can be registered and deprecated message matches

Screenshot 2025-01-14 at 8 31 04 PM

@topher-lo topher-lo added enhancement New feature or request internal Internal changes api Improvements or additions to the backend API labels Jan 15, 2025
@topher-lo topher-lo removed the internal Internal changes label Jan 15, 2025
@topher-lo topher-lo changed the title feat+chore: Deprecate unnormalized actions feat: Add deprecated field to RegistryAction Jan 15, 2025
@topher-lo topher-lo requested a review from daryllimyt January 15, 2025 04:38
@daryllimyt
Copy link
Contributor

Will review once tests are passing

daryllimyt
daryllimyt approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@daryllimyt daryllimyt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one import change

alembic/versions/849db8d3b59d_add_deprecated_field_to_.py

from alembic import op
import sqlalchemy as sa
import sqlmodel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import sqlmodel
import sqlmodel.sql.sqltypes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daryllimyt daryllimyt daryllimyt approved these changes

Assignees
No one assigned
Labels
api Improvements or additions to the backend API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topher-lo @daryllimyt