Adding project on the fly when tracking donations #49

jorgesancha · 2014-12-09T11:50:57Z

This PR addresses #6 and #44. In summary, it is now possible to add projects on the fly when tracking donations.

Replaced 'autocomplete-rails' by 'select2'
Added new project fields (description + url) if user chooses to add new project
Changed a bit how anonymous donations work - you are now redirected to the "signup" page rather than getting the "signup" form everywhere you go, which was causing some confusing UX (double sign-up form, or the donation form again, etc.)
Added a couple of happy-path specs for both logged in/anonymous donations.
Rebased all the Currency commits so that this branch can be merged automatically

There is still some work to do. We can either create new issues or commit more into this branch:

If something goes wrong on creation (e.g. Project description is too short), the donation form that shows up doesn't provide good error messages. It is not clear why it failed. @ferblape, I'd very much welcome your input on what's The Rails Way ™️ of doing this
I haven't worried about I18n this time, particularly about the 'Add project' literal being used in the coffeescript code
There is an ugly double-flash looking message when you TrackDon and SignUp at the same time.

Conflicts: Gemfile Gemfile.lock

ferblape · 2014-12-10T07:13:44Z

Hey @jorgesancha I have merged the latest master commits in your branch fixing a couple of conflicts.

I'll take a look at what you mention about the errors later.

jorgesancha · 2014-12-10T09:02:18Z

Thanks @ferblape , ping me on whatsapp if you want to do a hangout or sthg.

ferblape · 2014-12-12T07:08:30Z

I'm slowly progressing on this one, but it'll be ready for the weekend. I'm
using
http://apidock.com/rails/ActiveRecord/NestedAttributes/ClassMethods/accepts_nested_attributes_for,
which is the Rails way.

I'm also taking advantage of this PR to refactor a bit the cookies thing
and solve a couple of small bugs.

On Wed, Dec 10, 2014 at 10:02 AM, Jorge Gomez Sancha <
[email protected]> wrote:

Thanks @ferblape https://github.com/ferblape , ping me on whatsapp if
you want to do a hangout or sthg.

—
Reply to this email directly or view it on GitHub
#49 (comment).

jorgesancha · 2014-12-12T09:59:46Z

Thanks Fer! I tried accepts_nested_attributes_for but had problems with strong parameters and thought maybe it wasn't for a belongs_to association. Looking fwd to see how you address it

Sent from my iPhone

On 12/12/2014, at 8:08, Fernando Blat [email protected] wrote:

I'm slowly progressing on this one, but it'll be ready for the weekend. I'm
using
http://apidock.com/rails/ActiveRecord/NestedAttributes/ClassMethods/accepts_nested_attributes_for,
which is the Rails way.

I'm also taking advantage of this PR to refactor a bit the cookies thing
and solve a couple of small bugs.

On Wed, Dec 10, 2014 at 10:02 AM, Jorge Gomez Sancha <
[email protected]> wrote:

Thanks @ferblape https://github.com/ferblape , ping me on whatsapp if
you want to do a hangout or sthg.

—
Reply to this email directly or view it on GitHub
#49 (comment).

—
Reply to this email directly or view it on GitHub.

Apart from that, a few refactors in the method that sets the parameters of the donation in the cookies when the user is not logged in

ferblape · 2014-12-14T10:12:23Z

Merged and released!

furilo · 2014-12-16T09:17:14Z

Maybe there is something left to merge? I'm getting:

Showing /Users/alvaro/Web/trackdons/app/views/projects/new.html.erb where line #26 raised:

undefined local variable or method `autocomplete_project_name_projects_path' for #<#<Class:0x007ffc31b7de48>:0x007ffc31ea3e38>

ferblape · 2014-12-16T21:53:06Z

I'm afraid I broke that template. Before my changes, was the name of the project in that forma an autocomplete field?

ferblape · 2014-12-17T07:25:58Z

The simple fix is this one:

https://github.com/furilo/trackdons/compare/fix-projects-form?expand=1#diff-0

But I'd like to understand what was the previous code doing.

On Tue, Dec 16, 2014 at 10:17 AM, Álvaro Ortiz [email protected]
wrote:

Maybe there is something left to merge? I'm getting:

Showing /Users/alvaro/Web/trackdons/app/views/projects/new.html.erb where line #26 raised:

undefined local variable or method `autocomplete_project_name_projects_path' for #<#Class:0x007ffc31b7de48:0x007ffc31ea3e38>

—
Reply to this email directly or view it on GitHub
#49 (comment).

furilo · 2014-12-17T07:56:36Z

Its just from the previous gem for the autoselect, hence it can be removed.
But we would have to include there the new select-2 thing so if someone is
entering a project that already exists, he notice it.

On Wed, Dec 17, 2014 at 8:25 AM, Fernando Blat [email protected]
wrote:

The simple fix is this one:

https://github.com/furilo/trackdons/compare/fix-projects-form?expand=1#diff-0

But I'd like to understand what was the previous code doing.

On Tue, Dec 16, 2014 at 10:17 AM, Álvaro Ortiz [email protected]
wrote:

Maybe there is something left to merge? I'm getting:

Showing /Users/alvaro/Web/trackdons/app/views/projects/new.html.erb
where line #26 raised:

undefined local variable or method
`autocomplete_project_name_projects_path' for
#<#Class:0x007ffc31b7de48:0x007ffc31ea3e38>

—
Reply to this email directly or view it on GitHub
#49 (comment).

—
Reply to this email directly or view it on GitHub
#49 (comment).

http://www.mumumio.com
http://www.furilo.com

ferblape · 2014-12-21T10:49:31Z

Can projects be created without being logged in?

On Wed, Dec 17, 2014 at 8:56 AM, Álvaro Ortiz [email protected]
wrote:

Its just from the previous gem for the autoselect, hence it can be
removed.
But we would have to include there the new select-2 thing so if someone is
entering a project that already exists, he notice it.

On Wed, Dec 17, 2014 at 8:25 AM, Fernando Blat [email protected]
wrote:

The simple fix is this one:

https://github.com/furilo/trackdons/compare/fix-projects-form?expand=1#diff-0

But I'd like to understand what was the previous code doing.

On Tue, Dec 16, 2014 at 10:17 AM, Álvaro Ortiz [email protected]

wrote:

Maybe there is something left to merge? I'm getting:

Showing /Users/alvaro/Web/trackdons/app/views/projects/new.html.erb
where line #26 raised:

undefined local variable or method
`autocomplete_project_name_projects_path' for
#<#Class:0x007ffc31b7de48:0x007ffc31ea3e38>

—
Reply to this email directly or view it on GitHub
#49 (comment).

—
Reply to this email directly or view it on GitHub
#49 (comment).

http://www.mumumio.com
http://www.furilo.com

—
Reply to this email directly or view it on GitHub
#49 (comment).

ferblape · 2014-12-21T15:45:07Z

Instad of integrating select2, what do you think about this interaction?

This is the PR: #55

furilo · 2014-12-22T09:39:20Z

Great @ferblape. Maybe we could make that the text that appears contains a link so you can go and visit the said project?

furilo · 2014-12-24T10:21:32Z

BTW, regarding if anyone can create a project, I would leave that way until we encounter user vandalism ;)

ferblape · 2014-12-24T16:04:49Z

Done!

Are you planning to add pictures to the projects?

On Wed, Dec 24, 2014 at 11:21 AM, Álvaro Ortiz [email protected]
wrote:

BTW, regarding if anyone can create a project, I would leave that way
until we encounter user vandalism ;)

—
Reply to this email directly or view it on GitHub
#49 (comment).

Jorge Gomez Sancha added 5 commits December 9, 2014 12:23

Working version of Add new project with Select2

6014099

Getting rid of old commented-code

b0041e6

Refactored anonymous donation with support for new project

a8d701d

I missed this when rebasing

dfb23c1

Tiny css fix

5ab35e5

jorgesancha added the in progress label Dec 9, 2014

furilo mentioned this pull request Dec 9, 2014

If you have an account but save a donation without being logged in, save your donation when you login #50

Closed

Merge branch 'master' into select_2

db2fd1b

Conflicts: Gemfile Gemfile.lock

ferblape self-assigned this Dec 10, 2014

Refactor project from included in donation form

ba8cea0

Apart from that, a few refactors in the method that sets the parameters of the donation in the cookies when the user is not logged in

ferblape merged commit ba8cea0 into master Dec 14, 2014

ferblape deleted the select_2 branch December 14, 2014 10:10

ferblape removed the in progress label Dec 14, 2014

ferblape mentioned this pull request Dec 21, 2014

Show an error message when trying to create a project that already exists #55

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding project on the fly when tracking donations #49

Adding project on the fly when tracking donations #49

jorgesancha commented Dec 9, 2014

ferblape commented Dec 10, 2014

jorgesancha commented Dec 10, 2014

ferblape commented Dec 12, 2014

jorgesancha commented Dec 12, 2014

ferblape commented Dec 14, 2014

furilo commented Dec 16, 2014

ferblape commented Dec 16, 2014

ferblape commented Dec 17, 2014

furilo commented Dec 17, 2014

ferblape commented Dec 21, 2014

ferblape commented Dec 21, 2014

furilo commented Dec 22, 2014

furilo commented Dec 24, 2014

ferblape commented Dec 24, 2014

Adding project on the fly when tracking donations #49

Adding project on the fly when tracking donations #49

Conversation

jorgesancha commented Dec 9, 2014

ferblape commented Dec 10, 2014

jorgesancha commented Dec 10, 2014

ferblape commented Dec 12, 2014

jorgesancha commented Dec 12, 2014

ferblape commented Dec 14, 2014

furilo commented Dec 16, 2014

ferblape commented Dec 16, 2014

ferblape commented Dec 17, 2014

furilo commented Dec 17, 2014

ferblape commented Dec 21, 2014

ferblape commented Dec 21, 2014

furilo commented Dec 22, 2014

furilo commented Dec 24, 2014

ferblape commented Dec 24, 2014