Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsComplexType throws a System.NullReferenceException. #225

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

emperador-ming
Copy link

@emperador-ming emperador-ming commented Feb 20, 2019

#224
TrackableEntities.EF6.DbContextExtensions.IsComplexType throws a System.NullReferenceException.
50474341-a60a0480-09d1-11e9-91b6-1941ba0a8262

We're having this problem in production environment. Since TrackableEntities is a nuget dependency of Urf. Respository we cannot patch the bug. Should we download TrackableEntities library project, compile it and fix it for ourseleves?

@emperador-ming emperador-ming changed the title Master IsComplexType throws a System.NullReferenceException. Feb 20, 2019
@emperador-ming emperador-ming marked this pull request as ready for review February 20, 2019 16:34
@tonysneed
Copy link
Collaborator

Hi @emperador-ming. Thanks so much for your PR. Sorry for the delay ... didn't see it until now.

Can you please do me a favor and paste your change here, or submit a new PR. This PR was not performed correctly, and I can't seem to find your commit(s). This PR is for merging develop into master, which is incorrect.

The first step in creating a PR is to fork the repo, then create a new feature branch off develop. Make sure your changes, commit them, then push your branch. Then in GitHub you can create a PR from there.

@emperador-ming
Copy link
Author

Thank you for the instructions, @tonysneed. I'll do it ASAP. Right now I'm involved in a time-pressured delivery and we've replaced URF strategy completely due to crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants