Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tt-11 replace build configs and add core comps with example templates #7

Merged
merged 27 commits into from
Feb 5, 2024
Merged

feat: tt-11 replace build configs and add core comps with example templates #7

merged 27 commits into from
Feb 5, 2024

Conversation

MinHtet-O
Copy link
Contributor

@MinHtet-O MinHtet-O commented Jan 31, 2024 •
edited
Loading

Description
TT-11

Changes Made

  • replace with the build configs from generic templates
  • add the core components to the repo
  • remove testcases and test related dependencies ( for eg jest )
  • delete existing templates and add example templates with example on how to use those core components
  • update the README accordingly about core components
  • remove snyk check from github ci to avoid vulnerability issues for down stream dependencies
  • set node runtime to 18
  • upgrade to storybook version 7

Min Htet Oo added 24 commits January 25, 2024 16:53
delete everything and copy everything from generic template except Re…
2c08163 
…adme
delete unnecessary templates
78d7503 
delete organization logos
remove unit tests for v3 v4 and removed templates
dd0f44a
change path for example templates in documentation
b459410 
explain example templates
modify the steps to create new templates
remove tests
2b85639
add new package @govtechsg/open-attestation
2383adf
add watermark svg
97bd52d
remove signature component
aac911d 
update Readme to explain individual core components
remove example template header
fb11415
change heading level for core component
caa5de9
remove unnecessary print water mark imports
84aa784
update Readme core directory
a22b5aa
update watermark. so, it appears on all the printed page
1fa5db4
group Group example templates under example folder /src/templates/exa…
0858510 
…mple/TemplateA and TemplateB
upgrade version of @govtechsg/tradetrust-ui-components
0fbd3b2
upgarde packages accordingly with npm audit fix and synk check on ci
c943640
explicit set version of tradetrust-ui-components dependency to 2.3.3
d5f63ef
fix: replace package @govtechsg/tradetrust-ui-components to @tradetru…
e1a63c7 
…st-tt/tradetrust-ui-components to fix synk check on ci/cd
chore: remove unnessary test dependencies
84d470b
fix: remove snyk check from ci workflow
b3e3c03
chore: specify node 18 is required for this proj
fdf582c
chore: upgrade node-version for ci
62afd9b
fix command to build storybook ci
4453711
chore: upgrade storybook to v7
3e10b55
@MinHtet-O MinHtet-O requested a review from rongquan1 January 31, 2024 08:30
@MinHtet-O MinHtet-O changed the title Feature/tt-11 replace build configs and add core comps with example templates feat: tt-11 replace build configs and add core comps with example templates Feb 1, 2024
@MinHtet-O MinHtet-O merged commit 71a6be3 into master Feb 5, 2024
1 check passed
@MinHtet-O MinHtet-O deleted the feature/tt-11-replace-repo-include-core-comps branch February 5, 2024 01:42
@john-dot-oa john-dot-oa mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongquan1 rongquan1 rongquan1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MinHtet-O @rongquan1