Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reject Beneficiary or Holder condition revised if (account is beneficiary and holder #970

Open
wants to merge 1 commit into
base: v5
Choose a base branch
from

Conversation

ShadyAkhtar
Copy link

Summary

What is the background of this pull request?

Changes

  • What are the changes made in this pull request?
  • canRejectHolderTransfer & canRejectOwnerTransfer conditional check revised, as per token-registry v5 condition for reject beneficiary transfer or reject holder trasfer is account should not be beneficiary and holder

Reference

Issues

What are the related issues or stories?
Conditional check missing for canRejectHolderTransfer & canRejectOwnerTransfer which leads to Smart contract revert error "0x8c90bf45".

error:

{
    "code": -32603,
    "message": "Internal JSON-RPC error.",
    "data": {
        "code": -32603,
        "message": "VM Exception while processing transaction: revert",
        "data": "0x8c90bf45",
        "cause": null
    },
    "stack": "{\n  \"code\": -32603,\n  \"message\": \"Internal JSON-RPC error.\",\n  \"data\": {\n    \"code\": -32603,\n    \"message\": \"VM Exception while processing transaction: revert\",\n    \"data\": \"0x8c90bf45\",\n    \"cause\": null\n  },\n  \"stack\": \"Error: Internal JSON-RPC error.\\n    at new o (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:653344)\\n    at a (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:656577)\\n    at Object.internal (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:657186)\\n    at c (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:398667)\\n    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:399669\\n    at async chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:648682\"\n}\n  at new o (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:653344)\n  at a (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:656577)\n  at Object.internal (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:657186)\n  at c (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:398667)\n  at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:399669\n  at async chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:648682"
}

# Decoded Error
{
  "name": "DualRoleRejectionRequired",
  "params": []
}

image

Copy link

netlify bot commented Jan 10, 2025

👷 Deploy request for v5-dev-tradetrust-website pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b99e21b

Copy link

netlify bot commented Jan 10, 2025

👷 Deploy request for v5-tradetrust-website pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b99e21b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant