Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard #68

Merged
merged 31 commits into from
Nov 11, 2024
Merged

Dashboard #68

merged 31 commits into from
Nov 11, 2024

Conversation

ryanhayame
Copy link
Contributor

@ryanhayame ryanhayame commented Oct 22, 2024 •
edited
Loading

Created localhost dashboard to manage skypilot/kubernetes/kueue workloads.

Features include:

  1. Grafana konduktor dashboard embedding
  2. Loki live logs (search + filtering by namespace)
  3. Kueue UI to view, delete, and modify priority of workloads

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)

(you should review kube-prometheus-stack.values changes closely)

ryanhayame added 19 commits August 5, 2024 03:42
@ryanhayame
dashboard v0
2036378
@ryanhayame
Merge branch 'main' of https://github.com/Trainy-ai/konduktor into da…
ffceab0 
…shboard
@ryanhayame
websocket logs
86054b1
@ryanhayame
Merge branch 'main' of https://github.com/Trainy-ai/konduktor into da…
00aeb1e 
…shboard
@ryanhayame
logging
2a8b53e
@ryanhayame
Merge branch 'main' of https://github.com/Trainy-ai/konduktor into da…
a50e1cb 
…shboard
@ryanhayame
update
de3a64c
@ryanhayame
Merge branch 'main' of https://github.com/Trainy-ai/konduktor into da…
c9f85a2 
…shboard
@ryanhayame
dockerfiles + docker-compose
d0f58c3
@ryanhayame
backend.default.svc.cluster.local:5001 (broken APIs)
29b71ad
@ryanhayame
Merge branch 'main' of https://github.com/Trainy-ai/konduktor into da…
337815b 
…shboard
@ryanhayame
Merge branch 'main' of https://github.com/Trainy-ai/konduktor into da…
828932c 
…shboard
@ryanhayame
v0.5 dashboard
77bc13f
@ryanhayame
dashboard 0.7
da543a5
@ryanhayame
Merge branch 'main' of https://github.com/Trainy-ai/konduktor into da…
a283ecc 
…shboard
@ryanhayame
Merge branch 'main' of https://github.com/Trainy-ai/konduktor into da…
14cc432 
…shboard
@ryanhayame
dashboard v0.9
ba86274
@ryanhayame
DASHBOARD V1.0
ff36f53
@ryanhayame
dashboard 1.01
bb9aae0
asaiacai
asaiacai reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@asaiacai asaiacai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. left some comments mostly around moving stuff around.

konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/requirements.txt Outdated Show resolved Hide resolved
konduktor/dashboard/backend/Dockerfile Outdated Show resolved Hide resolved
konduktor/dashboard/frontend/Dockerfile Outdated Show resolved Hide resolved
konduktor/dashboard/frontend/README.md Outdated Show resolved Hide resolved
@Trainy-ai Trainy-ai deleted a comment from sweep-ai bot Nov 5, 2024
asaiacai
asaiacai requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@asaiacai asaiacai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. i'll probably have you walk through it with me before merging but this lgtm

konduktor/dashboard/backend/sockets.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/sockets.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/sockets.py Outdated Show resolved Hide resolved
@Trainy-ai Trainy-ai deleted a comment from sweep-ai bot Nov 7, 2024
asaiacai
asaiacai requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@asaiacai asaiacai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please consolidate the logging logic to konduktor/logging.py

konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
asaiacai
asaiacai approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@asaiacai asaiacai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm. awesome work @ryanhayame

@asaiacai asaiacai merged commit 1fa2c4d into main Nov 11, 2024
3 checks passed
@asaiacai asaiacai deleted the dashboard branch November 11, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asaiacai asaiacai asaiacai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanhayame @asaiacai