Fix various warnings #135
Merged
Fix various warnings #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'foo' parameter is not used and triggers a compilation warning. Signed-off-by: Adrien Ricciardi <[email protected]>
The 'error' parameter is not used when the shutdown hook support is not enabled and triggers a warning in and triggers a compilation warning in os/tpl_os_os_kernel.c, function tpl_call_shutdown_os(). Signed-off-by: Adrien Ricciardi <[email protected]>
…ack_footprint(). The 'proc_id' parameter is not used and triggers a compilation warning. Signed-off-by: Adrien Ricciardi <[email protected]>
The 'task_id' and 'incoming_event' parameters are not used and trigger a compilation warning. Signed-off-by: Adrien Ricciardi <[email protected]>
|
@jlbirccyn, are you OK if I send some PRs like this with fixes for the warnings I find while developing ? |
The 'n' parameter is not used and triggers a compilation warning. Signed-off-by: Adrien Ricciardi <[email protected]>
…l_resume_os_interrupts_service() because they were always true. The 'GET_LOCK_CNT_FOR_CORE' macro returns the 'tpl_locking_depth' variable, which is unsigned. Thus, checking if it is greater or equal to zero is always true. Signed-off-by: Adrien Ricciardi <[email protected]>
…ext_trampoline(). The 'sigid' arameter is not used and triggers a compilation warning. Signed-off-by: Adrien Ricciardi <[email protected]>
|
Yes I am ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed various warnings that were bothering me during development.