This repository has been archived by the owner on Aug 27, 2023. It is now read-only.
Force "continuous temperature read" mode in the simulator #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the new algorithm breaks some test in the simulator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulator's --report-temptable functionality is broken by the new reduced-workload ADC conversions. If we turn on continuous read mode we will get a result every time. This makes sense for this simulator function, though we may want to address it with more finesse in the future, for example, making the simulator aware of the need and thereby testing the periodic ADC kickstart functions in simulator mode.
But maybe that's crazy.
TBD: Need to add a test to regressiontests to catch this falling over again.