feat: support Node20 runner #90
Open
+33,603
−10,457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kengo TODA <[email protected]>
KengoTODA
commented
Oct 16, 2024
Comment on lines
89
to
+94
| - name: Checkout | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v4 | ||
| - name: Set up Node | ||
| uses: actions/setup-node@v1 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 12 | ||
| node-version: 20 |
There was a problem hiding this comment.
note: In my understanding these steps are needless, but I kept them to keep the diff minimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to an announcement from GitHub, Now
node20is used by default.This PR suggests to update dependencies and
action.yml, to make sure new version (assumed as1.5.0) works well on node20.I'm not sure which lock file should be updated, so I updated
yaml.lock.