Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete initial implementation for treating internal packages as external found with find_package() (#63) #560

Merged
merged 49 commits into from
Mar 29, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
ccb222a
Add printing of <Package>_PACAKGE_BUILD_STATUS (#63)
bartlettroscoe Dec 22, 2022
afcea28
Add documentation for <Package>_SUBPACKAGES varaible (#63)
bartlettroscoe Jan 12, 2023
ee5f2ce
Small doc update (#63)
bartlettroscoe Jan 13, 2023
0fc3973
Change tribits_print_prefix_string_and_list() to pass in list name (#63)
bartlettroscoe Jan 17, 2023
f3f9356
WIP: Add basic logic for setting <Package>_PACKAGE_BUILD_STATUS=EXTER…
bartlettroscoe Jan 24, 2023
09e61e5
WIP: rename some local vars away from UPPPER-CASE (#63)
bartlettroscoe Jan 18, 2023
5648cf7
WIP: Replace bool arg includeEmpty with enum arg enableEmptyStatus (#63)
bartlettroscoe Jan 18, 2023
abd846a
WIP: Small doc and format changes (#63)
bartlettroscoe Jan 18, 2023
cc8d5b7
WIP: Add internalOrExternal arg to tribits_print_packages_list_enable…
bartlettroscoe Jan 19, 2023
f85cc17
WIP: Change name from TribitsGetEnabledSublists.cmake to TribitsPacka…
bartlettroscoe Jan 19, 2023
e30b5bf
WIP: Change printing of package set lists based in INTERNAL/EXTERNAL …
bartlettroscoe Jan 20, 2023
e14b0d2
WIP: Add printing of Final set of [non-]enabled top-level external pa…
bartlettroscoe Jan 20, 2023
864ad9f
Factor out tribits_filter_package_list_from_var() (#63)
bartlettroscoe Jan 20, 2023
7ab3809
MockTrilinos: Set <Project>_TRACE_DEPENDENCY_HANDLING_ONLY=ON (#63)
bartlettroscoe Jan 21, 2023
aaec210
WIP: Adjust processing of internal and external packages (#63)
bartlettroscoe Jan 21, 2023
b9b4567
Finish basic implentation for building against external packages (#63)
bartlettroscoe Jan 24, 2023
33902f7
Process TPLs at base project level, pass info through <Package>Config…
bartlettroscoe Jan 27, 2023
a2790c8
Make WrapExernal work with external TribitsExProj packages (#63)
bartlettroscoe Jan 25, 2023
3065298
Add option <Project>_SKIP_INSTALL_PROJECT_CMAKE_CONFIG_FILES (#63)
bartlettroscoe Jan 25, 2023
aa843a4
WIP: Rename TribitsProcessEnabledTpl.cmake to TribitsProcessEnabledTp…
bartlettroscoe Jan 27, 2023
8e112e0
Add basic special handling for fully TriBITS-compliant external packa…
bartlettroscoe Jan 26, 2023
56b0845
WIP: Add initial failing test case for stagged package installs (#63)
bartlettroscoe Jan 27, 2023
cddd9f1
Initial implementation of pre-building/pre-installing stages of packa…
bartlettroscoe Jan 27, 2023
0c959bb
Revise how internal and external <Package>Config.cmake files are link…
bartlettroscoe Jan 28, 2023
2075dd6
WIP: Improve names of functions and variables (#63)
bartlettroscoe Feb 6, 2023
3b63fbd
WIP: Improve documentation (#63)
bartlettroscoe Feb 6, 2023
3389ceb
WIP: Move functions writing <tplName>Config.cmake files to TribitsExt…
bartlettroscoe Feb 6, 2023
28d1beb
WIP: Rename TribitsExternalPackageFindTplHelpers to TribitsExternalPa…
bartlettroscoe Feb 6, 2023
9a1eba1
WIP: Rename TribitsWriteClientExportFiles.cmake to TribitsInternalPac…
bartlettroscoe Feb 7, 2023
d8d60ae
WIP: Factor out TribitsProjectWriteConfigFile.cmake, reorder funcs (#63)
bartlettroscoe Feb 7, 2023
f14bba2
WIP: Rename func, remove unused funcs (#63)
bartlettroscoe Feb 7, 2023
bdd12c9
WIP: Remove 'Fully' from 'Fully TriBITS-Compliant' (and variations) (…
bartlettroscoe Feb 7, 2023
a2a5b99
Move 'CMake Language Overview and Gotchas' to appendix
bartlettroscoe Feb 9, 2023
61eaf6a
Remove debug print statement that got commited by accident
bartlettroscoe Feb 9, 2023
ba9de28
Adjust logic and printing for setting INTTERNAL packages as EXTERNAL …
bartlettroscoe Feb 18, 2023
80bd994
Update some outputing for TriBITS-compliant external packages (#63)
bartlettroscoe Feb 19, 2023
31de1fe
Add definitions of TriBITS-compliant packages (#63)
bartlettroscoe Feb 20, 2023
652d189
Add links to TriBITS-compliant external package in requirements for F…
bartlettroscoe Feb 20, 2023
8fc1e25
Add build ref item for treating internal packages as external (#634)
bartlettroscoe Feb 21, 2023
2bcc17f
Add CHANGLOG.md entry for -D<Project>_ENABLE_<TplName>=ON (#63, #546)
bartlettroscoe Feb 21, 2023
68c83ef
Add documentation for TriBITS-compliant external packages TRIBITS_PKG…
bartlettroscoe Feb 21, 2023
f8c1ea5
Add CHANGLOG.md entry for supporting pre-installed packages (#63)
bartlettroscoe Feb 21, 2023
f75343e
Merge remote-tracking branch 'github/master' into 63-combined-package…
bartlettroscoe Feb 25, 2023
2de8ca1
Merge branch 'master' into 63-combined-package-data-structures-6
bartlettroscoe Feb 25, 2023
f58975f
Merge remote-tracking branch 'github/master' into 63-combined-package…
bartlettroscoe Feb 28, 2023
90b96ee
Fix some documentation and add new functions to generated docs (#63, …
bartlettroscoe Mar 29, 2023
16b1817
Fix spelling of TribitsCMakeLanguageOverviewAndGotchas.rst (#63, #560)
bartlettroscoe Mar 29, 2023
014a153
Remove unused legacy RELATIVE_PATH code (#63, #560)
bartlettroscoe Mar 29, 2023
ee67e05
Merge remote-tracking branch 'github/master' into 63-combined-package…
bartlettroscoe Mar 29, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions test/core/ExamplesUnitTests/TribitsExampleProject2_Tests.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -935,18 +935,18 @@ function(TribitsExampleProject2_External_Package_by_Package
PASS_REGULAR_EXPRESSION_ALL
"Adjust the set of internal and external packages:"
"-- Treating internal package Package1 as EXTERNAL because TPL_ENABLE_Package1=ON"
"-- NOTE: Tpl1 is directly downstream from an fully TriBITS-compatible external package Package1"
"-- NOTE: Tpl1 is directly downstream from an TriBITS-compliant external package Package1"

"Final set of enabled top-level packages: Package2 1"
"Final set of non-enabled top-level packages: Package3 1"
"Final set of enabled top-level external packages/TPLs: Tpl1 Tpl2 Tpl3 Package1 4"
"Final set of non-enabled top-level external packages/TPLs: Tpl4 1"

"Getting information for all enabled fully TriBITS-compatible or upstream external packages/TPLs ..."
"Getting information for all enabled TriBITS-compliant or upstream external packages/TPLs ..."
"Processing enabled external package/TPL: Tpl1 [(]enabled by Package1, disable with -DTPL_ENABLE_Tpl1=OFF[)]"
"-- The external package/TPL Tpl1 will be read in by a downstream fully TriBITS-compliant external package"
"-- The external package/TPL Tpl1 will be read in by a downstream TriBITS-compliant external package"
"Processing enabled external package/TPL: Package1 [(]enabled explicitly, disable with -DTPL_ENABLE_Package1=OFF[)]"
"-- Calling find_package[(]Package1[)] for TriBITS-compatible package"
"-- Calling find_package[(]Package1[)] for TriBITS-compliant package"

"Getting information for all enabled external packages/TPLs ..."
"Processing enabled external package/TPL: Tpl2 [(]enabled explicitly, disable with -DTPL_ENABLE_Tpl2=OFF[)]"
Expand Down Expand Up @@ -998,28 +998,28 @@ function(TribitsExampleProject2_External_Package_by_Package
"Adjust the set of internal and external packages:"
"-- Treating internal package Package2 as EXTERNAL because TPL_ENABLE_Package2=ON"
"-- Treating internal package Package1 as EXTERNAL because downstream package Package2 being treated as EXTERNAL"
"-- NOTE: Package1 is directly downstream from an fully TriBITS-compatible external package Package2"
"-- NOTE: Tpl3 is directly downstream from an fully TriBITS-compatible external package Package2"
"-- NOTE: Tpl1 is indirectly downstream from an fully TriBITS-compatible external package"
"-- NOTE: Tpl2 is indirectly downstream from an fully TriBITS-compatible external package"
"-- NOTE: Tpl1 is indirectly downstream from an fully TriBITS-compatible external package"
"-- NOTE: Package1 is directly downstream from an TriBITS-compliant external package Package2"
"-- NOTE: Tpl3 is directly downstream from an TriBITS-compliant external package Package2"
"-- NOTE: Tpl1 is indirectly downstream from an TriBITS-compliant external package"
"-- NOTE: Tpl2 is indirectly downstream from an TriBITS-compliant external package"
"-- NOTE: Tpl1 is indirectly downstream from an TriBITS-compliant external package"

"Final set of enabled top-level packages: Package3 1"
"Final set of non-enabled top-level packages: 0"
"Final set of enabled top-level external packages/TPLs: Tpl1 Tpl2 Tpl3 Tpl4 Package1 Package2 6"
"Final set of non-enabled top-level external packages/TPLs: 0"

"Getting information for all enabled fully TriBITS-compatible or upstream external packages/TPLs ..."
"Getting information for all enabled TriBITS-compliant or upstream external packages/TPLs ..."
"Processing enabled external package/TPL: Tpl1 [(]enabled explicitly, disable with -DTPL_ENABLE_Tpl1=OFF[)]"
"-- The external package/TPL Tpl1 will be read in by a downstream fully TriBITS-compliant external package"
"-- The external package/TPL Tpl1 will be read in by a downstream TriBITS-compliant external package"
"Processing enabled external package/TPL: Tpl2 [(]enabled explicitly, disable with -DTPL_ENABLE_Tpl2=OFF[)]"
"-- The external package/TPL Tpl2 will be read in by a downstream fully TriBITS-compliant external package"
"-- The external package/TPL Tpl2 will be read in by a downstream TriBITS-compliant external package"
"Processing enabled external package/TPL: Tpl3 [(]enabled explicitly, disable with -DTPL_ENABLE_Tpl3=OFF[)]"
"-- The external package/TPL Tpl3 will be read in by a downstream fully TriBITS-compliant external package"
"-- The external package/TPL Tpl3 will be read in by a downstream TriBITS-compliant external package"
"Processing enabled external package/TPL: Package1 [(]enabled explicitly, disable with -DTPL_ENABLE_Package1=OFF[)]"
"-- The external package/TPL Package1 will be read in by a downstream fully TriBITS-compliant external package"
"-- The external package/TPL Package1 will be read in by a downstream TriBITS-compliant external package"
"Processing enabled external package/TPL: Package2 [(]enabled explicitly, disable with -DTPL_ENABLE_Package2=OFF[)]"
"-- Calling find_package[(]Package2[)] for TriBITS-compatible package"
"-- Calling find_package[(]Package2[)] for TriBITS-compliant package"
"Getting information for all enabled external packages/TPLs ..."

"Processing enabled external package/TPL: Tpl4 [(]enabled explicitly, disable with -DTPL_ENABLE_Tpl4=OFF[)]"
Expand Down
46 changes: 23 additions & 23 deletions test/core/ExamplesUnitTests/TribitsExampleProject_Tests.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3297,8 +3297,8 @@ tribits_add_advanced_test( TribitsExampleProject_External_SimpleCxx
PASS_REGULAR_EXPRESSION_ALL
"Adjust the set of internal and external packages:"
"-- Treating internal package SimpleCxx as EXTERNAL because TPL_ENABLE_SimpleCxx=ON"
"-- NOTE: HeaderOnlyTpl is directly downstream from an fully TriBITS-compatible external package SimpleCxx"
"-- NOTE: SimpleTpl is directly downstream from an fully TriBITS-compatible external package SimpleCxx"
"-- NOTE: HeaderOnlyTpl is directly downstream from an TriBITS-compliant external package SimpleCxx"
"-- NOTE: SimpleTpl is directly downstream from an TriBITS-compliant external package SimpleCxx"

"Final set of enabled top-level packages: MixedLang WithSubpackages WrapExternal 3"
"Final set of enabled packages: MixedLang WithSubpackagesA WithSubpackagesB WithSubpackagesC WithSubpackages WrapExternal 6"
Expand All @@ -3309,13 +3309,13 @@ tribits_add_advanced_test( TribitsExampleProject_External_SimpleCxx
"Final set of non-enabled top-level external packages/TPLs: MPI 1"
"Final set of non-enabled external packages/TPLs: MPI 1"

"Getting information for all enabled fully TriBITS-compatible or upstream external packages/TPLs ..."
"Getting information for all enabled TriBITS-compliant or upstream external packages/TPLs ..."
"Processing enabled external package/TPL: HeaderOnlyTpl [(]enabled by SimpleCxx, disable with -DTPL_ENABLE_HeaderOnlyTpl=OFF[)]"
"-- The external package/TPL HeaderOnlyTpl will be read in by a downstream fully TriBITS-compliant external package"
"-- The external package/TPL HeaderOnlyTpl will be read in by a downstream TriBITS-compliant external package"
"Processing enabled external package/TPL: SimpleTpl [(]enabled explicitly, disable with -DTPL_ENABLE_SimpleTpl=OFF[)]"
"-- The external package/TPL SimpleTpl will be read in by a downstream fully TriBITS-compliant external package"
"-- The external package/TPL SimpleTpl will be read in by a downstream TriBITS-compliant external package"
"Processing enabled external package/TPL: SimpleCxx [(]enabled explicitly, disable with -DTPL_ENABLE_SimpleCxx=OFF[)]"
"-- Calling find_package[(]SimpleCxx[)] for TriBITS-compatible package"
"-- Calling find_package[(]SimpleCxx[)] for TriBITS-compliant package"

"Getting information for all enabled external packages/TPLs ..."

Expand Down Expand Up @@ -3489,18 +3489,18 @@ tribits_add_advanced_test( TribitsExampleProject_External_Package_by_Package
"-- Treating internal package WithSubpackagesA as EXTERNAL because downstream package WithSubpackages being treated as EXTERNAL"
"-- Treating internal package WithSubpackagesB as EXTERNAL because downstream package WithSubpackages being treated as EXTERNAL"
"-- Treating internal package WithSubpackagesC as EXTERNAL because downstream package WithSubpackages being treated as EXTERNAL"
"-- NOTE: WithSubpackagesA is directly downstream from an fully TriBITS-compatible external package WithSubpackages"
"-- NOTE: WithSubpackagesB is directly downstream from an fully TriBITS-compatible external package WithSubpackages"
"-- NOTE: WithSubpackagesC is directly downstream from an fully TriBITS-compatible external package WithSubpackages"
"-- NOTE: WithSubpackagesA is indirectly downstream from an fully TriBITS-compatible external package"
"-- NOTE: WithSubpackagesB is indirectly downstream from an fully TriBITS-compatible external package"
"-- NOTE: WithSubpackagesA is directly downstream from an TriBITS-compliant external package WithSubpackages"
"-- NOTE: WithSubpackagesB is directly downstream from an TriBITS-compliant external package WithSubpackages"
"-- NOTE: WithSubpackagesC is directly downstream from an TriBITS-compliant external package WithSubpackages"
"-- NOTE: WithSubpackagesA is indirectly downstream from an TriBITS-compliant external package"
"-- NOTE: WithSubpackagesB is indirectly downstream from an TriBITS-compliant external package"
"-- Treating internal package SimpleCxx as EXTERNAL because downstream package WithSubpackagesB being treated as EXTERNAL"
"-- NOTE: SimpleCxx is indirectly downstream from an fully TriBITS-compatible external package"
"-- NOTE: WithSubpackagesA is indirectly downstream from an fully TriBITS-compatible external package"
"-- NOTE: SimpleCxx is indirectly downstream from an fully TriBITS-compatible external package"
"-- NOTE: SimpleCxx is indirectly downstream from an TriBITS-compliant external package"
"-- NOTE: WithSubpackagesA is indirectly downstream from an TriBITS-compliant external package"
"-- NOTE: SimpleCxx is indirectly downstream from an TriBITS-compliant external package"
"-- Treating internal package MixedLang as EXTERNAL because TPL_ENABLE_MixedLang=ON"
"-- NOTE: HeaderOnlyTpl is indirectly downstream from an fully TriBITS-compatible external package"
"-- NOTE: SimpleTpl is indirectly downstream from an fully TriBITS-compatible external package"
"-- NOTE: HeaderOnlyTpl is indirectly downstream from an TriBITS-compliant external package"
"-- NOTE: SimpleTpl is indirectly downstream from an TriBITS-compliant external package"

"Final set of enabled top-level packages: WrapExternal 1"
"Final set of enabled packages: WrapExternal 1"
Expand All @@ -3511,17 +3511,17 @@ tribits_add_advanced_test( TribitsExampleProject_External_Package_by_Package
"Final set of non-enabled top-level external packages/TPLs: MPI 1"
"Final set of non-enabled external packages/TPLs: MPI 1"

"Getting information for all enabled fully TriBITS-compatible or upstream external packages/TPLs ..."
"Getting information for all enabled TriBITS-compliant or upstream external packages/TPLs ..."
"Processing enabled external package/TPL: HeaderOnlyTpl [(]enabled by SimpleCxx, disable with -DTPL_ENABLE_HeaderOnlyTpl=OFF[)]"
"-- The external package/TPL HeaderOnlyTpl will be read in by a downstream fully TriBITS-compliant external package"
"-- The external package/TPL HeaderOnlyTpl will be read in by a downstream TriBITS-compliant external package"
"Processing enabled external package/TPL: SimpleTpl [(]enabled explicitly, disable with -DTPL_ENABLE_SimpleTpl=OFF[)]"
"-- The external package/TPL SimpleTpl will be read in by a downstream fully TriBITS-compliant external package"
"-- The external package/TPL SimpleTpl will be read in by a downstream TriBITS-compliant external package"
"Processing enabled external package/TPL: SimpleCxx [(]enabled explicitly, disable with -DTPL_ENABLE_SimpleCxx=OFF[)]"
"-- The external package/TPL SimpleCxx will be read in by a downstream fully TriBITS-compliant external package"
"-- The external package/TPL SimpleCxx will be read in by a downstream TriBITS-compliant external package"
"Processing enabled external package/TPL: MixedLang [(]enabled explicitly, disable with -DTPL_ENABLE_MixedLang=OFF[)]"
"-- Calling find_package[(]MixedLang[)] for TriBITS-compatible package"
"-- Calling find_package[(]MixedLang[)] for TriBITS-compliant package"
"Processing enabled external package/TPL: WithSubpackages [(]enabled explicitly, disable with -DTPL_ENABLE_WithSubpackages=OFF[)]"
"-- Calling find_package[(]WithSubpackages[)] for TriBITS-compatible package"
"-- Calling find_package[(]WithSubpackages[)] for TriBITS-compliant package"

"Getting information for all enabled external packages/TPLs ..."

Expand Down Expand Up @@ -3555,7 +3555,7 @@ tribits_add_advanced_test( TribitsExampleProject_External_Package_by_Package
)
# NOTE: The above test is a strong check that packages can be installed
# individually in stages on top of each other and that we are correctly
# writing wrapper <Package>Config.cmake files for fully TriBITS-compatible
# writing wrapper <Package>Config.cmake files for TriBITS-compliant
# external packages (in this case for WithSubpackagesAConfig.cmake to
# include).

Expand Down
10 changes: 5 additions & 5 deletions tribits/core/package_arch/TribitsAdjustPackageEnables.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ endmacro()
# NOTE: Above, we are sweeping over *all* of the not-disabled packages listed
# in ${PROJECT_NAME}_DEFINED_INTERNAL_PACKAGES, including those package that
# might have <Package>_PACKAGE_BUILD_STATUS=EXTERNAL. That makes sense
# because these are TriBITS (or TriBITS compatible) packages so we should
# because these are TriBITS (or TriBITS-compliant) packages so we should
# assume that all of their downstream packages, whether internal or external,
# should be enabled as well. If we find this is not the desirable behavior,
# then we can change this later.
Expand Down Expand Up @@ -1321,7 +1321,7 @@ endmacro()


# Macro that sets all of the direct upstream dependent packages as being
# processed by a downstream fully TriBITS compliant external package.
# processed by a downstream TriBITS-compliant external package.
macro(tribits_set_package_and_deps_as_processed_by_downstream_tribits_external_package
packageName
)
Expand All @@ -1335,7 +1335,7 @@ macro(tribits_set_package_and_deps_as_processed_by_downstream_tribits_external_p
tribits_get_package_enable_status(${packageName} packageEnable "")

if (${packageName}_PACKAGE_BUILD_STATUS STREQUAL "EXTERNAL"
AND (${packageName}_IS_FULLY_TRIBITS_COMPLIANT
AND (${packageName}_IS_TRIBITS_COMPLIANT
OR ${packageName}_PROCESSED_BY_DOWNSTREAM_TRIBITS_EXTERNAL_PACKAGE)
)

Expand All @@ -1351,8 +1351,8 @@ macro(tribits_set_package_and_deps_as_processed_by_downstream_tribits_external_p
tribits_get_package_enable_status(${depPkg} depPkgEnable "")
if (depPkgEnable)
message("-- "
"NOTE: ${depPkg} is ${directOrIndirectStr} downstream from an fully"
" TriBITS-compatible external package${downstreamPkgStr}")
"NOTE: ${depPkg} is ${directOrIndirectStr} downstream from an"
" TriBITS-compliant external package${downstreamPkgStr}")
endif()
set(${depPkg}_PROCESSED_BY_DOWNSTREAM_TRIBITS_EXTERNAL_PACKAGE TRUE)
endforeach()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ function(tribits_extpkgwit_append_package_config_file_header_str
set(configFileStr "${${configFileStrVarInOut}}")
string(APPEND configFileStr
"# TriBITS-compliant Package config file for external package/TPL '${tplName}'\n"
"# based on non fully TriBITS-compliant external package '${externalPkg}' that uses\n"
"# based on non TriBITS-compliant external package '${externalPkg}' that uses\n"
"# modern IMPORTED targets\n"
"#\n"
"# Generated by CMake, do not edit!\n"
Expand Down
20 changes: 10 additions & 10 deletions tribits/core/package_arch/TribitsProcessEnabledTpls.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,15 @@ macro(tribits_process_enabled_tpls)
EXTERNAL ON NONEMPTY ${PROJECT_NAME}_enabledExternalTopLevelPackages)

message("")
message("Getting information for all enabled fully TriBITS-compatible"
message("Getting information for all enabled TriBITS-compliant"
" or upstream external packages/TPLs ...")
message("")

foreach(TPL_NAME IN LISTS ${PROJECT_NAME}_enabledExternalTopLevelPackages)
if (${TPL_NAME}_IS_FULLY_TRIBITS_COMPLIANT
if (${TPL_NAME}_IS_TRIBITS_COMPLIANT
OR ${TPL_NAME}_PROCESSED_BY_DOWNSTREAM_TRIBITS_EXTERNAL_PACKAGE
)
tribits_process_enabled_fully_tribits_compatible_or_upstream_tpl(${TPL_NAME})
tribits_process_enabled_tribits_compliant_or_upstream_tpl(${TPL_NAME})
endif()
endforeach()

Expand All @@ -76,7 +76,7 @@ macro(tribits_process_enabled_tpls)
message("")

foreach(TPL_NAME IN LISTS ${PROJECT_NAME}_enabledExternalTopLevelPackages)
if ((NOT ${TPL_NAME}_IS_FULLY_TRIBITS_COMPLIANT)
if ((NOT ${TPL_NAME}_IS_TRIBITS_COMPLIANT)
AND (NOT ${TPL_NAME}_PROCESSED_BY_DOWNSTREAM_TRIBITS_EXTERNAL_PACKAGE)
)
tribits_process_enabled_standard_tpl(${TPL_NAME})
Expand All @@ -89,18 +89,18 @@ macro(tribits_process_enabled_tpls)
endmacro()


macro(tribits_process_enabled_fully_tribits_compatible_or_upstream_tpl TPL_NAME)
macro(tribits_process_enabled_tribits_compliant_or_upstream_tpl TPL_NAME)

tribits_get_enabled_tpl_processing_string(${TPL_NAME} tplProcessingString)
message("${tplProcessingString}")

if (NOT ${PROJECT_NAME}_TRACE_DEPENDENCY_HANDLING_ONLY)
if (NOT ${TPL_NAME}_PROCESSED_BY_DOWNSTREAM_TRIBITS_EXTERNAL_PACKAGE)
tribits_process_enabled_tribits_compatible_tpl(${TPL_NAME})
tribits_process_enabled_tribits_compliant_tpl(${TPL_NAME})
else()
message("-- "
"The external package/TPL ${TPL_NAME} will be read in by a downstream"
" fully TriBITS-compliant external package")
" TriBITS-compliant external package")
endif()
endif()

Expand Down Expand Up @@ -147,12 +147,12 @@ function(tribits_get_enabled_tpl_processing_string TPL_NAME tplProcessingStrin
endfunction()


# Process an enabled TPL defined using a fully TriBITS-compatible external
# Process an enabled TPL defined using a TriBITS-compliant external
# packages <tplName>Config.cmake file
#
macro(tribits_process_enabled_tribits_compatible_tpl TPL_NAME)
macro(tribits_process_enabled_tribits_compliant_tpl TPL_NAME)
message("-- "
"Calling find_package(${TPL_NAME}) for TriBITS-compatible package")
"Calling find_package(${TPL_NAME}) for TriBITS-compliant package")
find_package(${TPL_NAME} CONFIG REQUIRED)
endmacro()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ macro(tribits_process_packages_and_dirs_lists REPOSITORY_NAME REPOSITORY_DIR)
set(${TRIBITS_PACKAGE}_PARENT_REPOSITORY ${REPOSITORY_NAME})
tribits_insert_standard_package_options(${TRIBITS_PACKAGE} ${PACKAGE_TESTGROUP})
set(${TRIBITS_PACKAGE}_PACKAGE_BUILD_STATUS INTERNAL)
set(${TRIBITS_PACKAGE}_IS_FULLY_TRIBITS_COMPLIANT TRUE)
set(${TRIBITS_PACKAGE}_IS_TRIBITS_COMPLIANT TRUE)
else()
if (${PROJECT_NAME}_VERBOSE_CONFIGURE)
message(
Expand All @@ -594,7 +594,7 @@ macro(tribits_process_packages_and_dirs_lists REPOSITORY_NAME REPOSITORY_DIR)
print_var(${TRIBITS_PACKAGE}_PARENT_PACKAGE)
print_var(${TRIBITS_PACKAGE}_PARENT_REPOSITORY)
print_var(${TRIBITS_PACKAGE}_PACKAGE_BUILD_STATUS)
print_var(${TRIBITS_PACKAGE}_IS_FULLY_TRIBITS_COMPLIANT)
print_var(${TRIBITS_PACKAGE}_IS_TRIBITS_COMPLIANT)
endif()

if (TRIBITS_PROCESS_PACKAGES_AND_DIRS_LISTS_VERBOSE)
Expand Down
Loading