Skip to content

Commit

Permalink
fix(gcp-cloud-run): No longer use gcloud beta when deploying with s…
Browse files Browse the repository at this point in the history
…ecrets
  • Loading branch information
TriPSs committed Dec 10, 2023
1 parent 5ffdeaf commit a5b189e
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions packages/gcp-cloud-run/src/executors/deploy/deploy.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,8 @@ export async function deployExecutor(
]))
}

let gcloudCommand = 'gcloud'
if (validSecrets.length > 0) {
logger.info('Using secrets, use gcloud beta')
gcloudCommand = 'gcloud beta'
}

const deployCommand = buildCommand([
`${gcloudCommand} run deploy ${name}`,
`gcloud run deploy ${name}`,
!buildWithArtifactRegistry && `--image=${containerName}`,
buildWithArtifactRegistry && '--source=./',
`--project=${project}`,
Expand Down

0 comments on commit a5b189e

Please sign in to comment.