Merge pull request #8015 from drew2a/fix/8010

Add dependency management to GUI tests
Tribler · May 1, 2024 · 202fc35 · 202fc35
2 parents 5ab51d1 + 8dcaae5
commit 202fc35
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/.github/workflows/vars/pytest.env b/.github/workflows/vars/pytest.env
@@ -10,7 +10,7 @@ PYTEST_TUNNELS_ARGUMENTS_WIN='${PYTEST_TUNNELS_ARGUMENTS}'
 PYTEST_TUNNELS_ARGUMENTS_LINUX='${PYTEST_TUNNELS_ARGUMENTS} --looptime'
 PYTEST_TUNNELS_ARGUMENTS_MAC='${PYTEST_TUNNELS_ARGUMENTS} --looptime'
 
-PYTEST_GUI_ARGUMENTS='./src/tribler/gui ${PYTEST_ARGUMENTS}'
+PYTEST_GUI_ARGUMENTS='./src/tribler/gui ${PYTEST_ARGUMENTS} --order-dependencies'
 PYTEST_GUI_ARGUMENTS_WIN='${PYTEST_GUI_ARGUMENTS}'
 PYTEST_GUI_ARGUMENTS_LINUX='${PYTEST_GUI_ARGUMENTS} --looptime'
 PYTEST_GUI_ARGUMENTS_MAC='${PYTEST_GUI_ARGUMENTS} --looptime'
diff --git a/requirements-test.txt b/requirements-test.txt
@@ -6,6 +6,8 @@ pytest-asyncio==0.21.1
 pytest-randomly==3.15.0
 pytest-timeout==2.2.0
 pylint-pytest==1.1.7
+pytest-dependency==0.6.0 # for GUI tests
+pytest-order==1.2.1 # for GUI tests
 
 coverage==7.3.2
 looptime==0.2 ; sys_platform != 'win32'

diff --git a/src/tribler/gui/tests/test_gui.py b/src/tribler/gui/tests/test_gui.py
@@ -323,6 +323,7 @@ def test_settings(window):
     wait_for_signal(window.settings_page.settings_edited)
 
 
+@pytest.mark.dependency
 def test_downloads(window):
     go_to_and_wait_for_downloads(window)
     screenshot(window, name="downloads_all")
@@ -336,6 +337,7 @@ def test_downloads(window):
     screenshot(window, name="downloads_inactive")
 
 
+@pytest.mark.dependency(depends=["test_downloads"])
 def test_download_start_stop_remove_recheck(window):
     go_to_and_wait_for_downloads(window)
     QTest.mouseClick(window.downloads_list.topLevelItem(0).progress_slider, Qt.LeftButton)
@@ -346,6 +348,7 @@ def test_download_start_stop_remove_recheck(window):
     QTest.mouseClick(window.downloads_page.dialog.buttons[2], Qt.LeftButton)
 
 
+@pytest.mark.dependency(depends=["test_downloads"])
 def test_download_details(window):
     go_to_and_wait_for_downloads(window)
     QTest.mouseClick(window.downloads_list.topLevelItem(0).progress_slider, Qt.LeftButton)