Refactor disk usage tracking and handling #7716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
requested review from
a team and
egbertbouman
and removed request for
a team
egbertbouman
approved these changes
Nov 25, 2023
- Refactored the `get_disk_usage` method to return an optional named tuple instead of a list - Updated the code to handle exceptions when retrieving disk usage information using `psutil.disk_usage` - Added a new test case to verify that disk usage is None when an exception occurs in `psutil.disk_usage` This commit improves the reliability and error handling of disk usage tracking in the resource monitor component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_disk_usagemethod to return an optional named tuple instead of a listpsutil.disk_usagepsutil.disk_usageThis commit improves the reliability and error handling of disk usage tracking in the resource monitor component.
Fixes #7712