Add an exclusion for the exception type found in the latest core output. #7722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, it includes the word 'warning' in the list of exclusions. Refactored the parse_last_core_output function to improve readability and maintainability. Added a regular expression pattern _re_search_exception_exclusions to exclude specific exception types from being parsed. Modified the parse_last_core_output function to skip parsing if an excluded exception type is found.
drew2a
requested review from
a team,
egbertbouman and
kozlovsky
and removed request for
a team and
egbertbouman
…entry_tools.py - Fix the regex pattern in `_re_search_exception` to properly match exception strings. - Add new test cases to `test_sentry_tools.py` for handling additional exception strings. This commit improves the accuracy of matching exception strings and expands the test coverage for handling different types of exceptions.
The regular expression for finding exceptions in the string has been fixed to correctly capture the exception name and message. Additionally, the exclusion pattern for warnings has been updated. The test cases have also been modified to reflect these changes.
…rs and underscores in sentry_tools.py The regular expression pattern used to find exceptions in strings has been updated to include alphanumeric characters and underscores. This ensures that exceptions with names like "pony_orm.core.TransactionIntegrityError" are correctly matched. Also, added test cases for strings that should not be matched in test_sentry_tools.py.
kozlovsky
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an exclusion for the exception type found in the latest core output. Specifically, it includes the word 'warning' in the list of exclusions.
parse_last_core_outputfunction to improve readability and maintainability._re_search_exception_exclusionsto exclude specific exception types from being parsed.parse_last_core_outputfunction to skip parsing if an excluded exception type is found.Fixes #7713