Use dedicated exit codes when another primary GUI/Core process is running #7746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
drew2a
and removed request for
a team
kozlovsky
changed the title
kozlovsky
force-pushed
the
exit_codes_another_process_is_running
branch
from
2772961 to
07107a4
Compare
kozlovsky
force-pushed
the
exit_codes_another_process_is_running
branch
from
07107a4 to
06112bb
Compare
drew2a
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the Tribler GUI/Core process detects that another primary process is running, it exits with the generic exit code 1.
It is better to have a separate exit code so CoreManager or ApplicationTester is able to see the reason for the sudden process termination. Introducing the specific exit codes should allow the separation of the different error reports in Sentry and the special handling of specific exit codes.