Modify check_free_space function to verify available disk space
#7760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
requested review from
a team and
qstokkink
and removed request for
a team
qstokkink
reviewed
Dec 8, 2023
| logger.info('Check free space') | ||
| def check_free_space(state_dir: Path): | ||
| """ Check if there is enough free space on the disk.""" | ||
| logger.info(f'Checking free space for the folder: {state_dir}') |
There was a problem hiding this comment.
NIT: Using f-strings in logging calls is generally discouraged (see for example https://pylint.readthedocs.io/en/stable/user_guide/messages/warning/logging-fstring-interpolation.html).
There was a problem hiding this comment.
We had this discussion before: #5611 :)
There was a problem hiding this comment.
Good point, I forgot about that. 👍
There was a problem hiding this comment.
Thank you for the suggestion. For this PR, I left the "f-string" version, but we can discuss it at the next dev meeting. In case of an altered agreement, I'll change the formatting for all upcoming pull requests.
qstokkink
approved these changes
Dec 8, 2023
This commit modifies the function `check_free_space`. The function checks if there is enough free space on the disk by calculating the disk usage of a specified folder. If the available space is less than 100MB, an error message is displayed and Tribler exits. The function also logs the amount of free space when it is sufficient. Additionally, in the `start_gui.py` module, the `check_free_space` function now takes a parameter specifying the root state directory to be checked for free space. Add test cases for check_free_space - Added new test cases for the `check_free_space` function to ensure it works correctly when there's sufficient disk space and raises an exception when there's insufficient disk space. - Also added test cases to check the behavior when there's an ImportError or OSError.
kozlovsky
pushed a commit
that referenced
this pull request
Mar 8, 2024
…le disk space This commit modifies the function `check_free_space`. The function checks if there is enough free space on the disk by calculating the disk usage of a specified folder. If the available space is less than 100MB, an error message is displayed and Tribler exits. The function also logs the amount of free space when it is sufficient. Additionally, in the `start_gui.py` module, the `check_free_space` function now takes a parameter specifying the root state directory to be checked for free space. Add test cases for check_free_space - Added new test cases for the `check_free_space` function to ensure it works correctly when there's sufficient disk space and raises an exception when there's insufficient disk space. - Also added test cases to check the behavior when there's an ImportError or OSError. (cherry picked from commit b2bc372)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the function
check_free_spaceto ignoreOSErrorsso they cannot lead to Tribler crashing.Additionally, in the
start_gui.pymodule, thecheck_free_spacefunction now takes a parameter specifying the root state directory to be checked for free space.Fixes #7745