Add logging statements to start_download_from_uri method
#7769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added logging statements to indicate the start of download from URI - Added logging statements to indicate the detection of different schemes (HTTP(s), Magnet, File) - Added logging statements to display name and infohash for Magnet scheme - Added logging statements to indicate if metainfo is found in cache or not - Added logging statement to indicate if file scheme is detected - Updated existing debug log statement with an info log statement in start_download method - Added logging statement to indicate that torrent def is None and trying to load it from torrent file - Added logging statement to indicate if download exists and metainfo is not requested - Created destination directory if it does not exist and added corresponding log statement
drew2a
requested review from
a team and
xoriole
and removed request for
a team
xoriole
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging for
start_download_from_uriwhich helps investigate bugs like:Changes: