Add tests for Path.fix_win_long_file
#7775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added import statements for `sys` and `patch` - Added two new test functions: `test_fix_win_long_file_win()` and `test_fix_win_long_file_linux()` - Each test function checks if the `fix_win_long_file` function returns the expected result on Windows and Linux respectively
- Refactored the `write` method in `DownloadConfig` class to accept a `filename` parameter of type `Path`. - Updated the code in `download.py` to pass the correct argument type when calling the `write` method. This commit improves code readability and ensures proper handling of file paths.
drew2a
requested review from
a team and
xoriole
and removed request for
a team
xoriole
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for
Path.fix_win_long_fileand contains a small refactoring forDownloadConfig.writethat I've done during the investigation of #5926.