Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed exception on bad torrent URL #8403

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Fixed exception on bad torrent URL #8403

merged 2 commits into from
Jan 21, 2025

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Jan 21, 2025 •
edited
Loading

Fixes #8360

This PR:

  • Fixes get_torrent_info not checking for decoding errors when processing an HTTP/HTTPS response.
  • Fixes the file download dialog toast error not using the correct locale string.
  • Updates the magnet add dialog to not show a SaveAs dialog when no torrent is available to download.

@qstokkink
Copy link
Contributor Author

I'll make changes to the GUI too: we are still showing the SaveAs dialog even if we don't have the necessary torrent/infohash to save anything.

@qstokkink
Copy link
Contributor Author

validate

@qstokkink qstokkink changed the title WIP: Fixed exception on bad torrent URL READY: Fixed exception on bad torrent URL Jan 21, 2025
@qstokkink qstokkink marked this pull request as ready for review January 21, 2025 09:11
@qstokkink qstokkink changed the title READY: Fixed exception on bad torrent URL Fixed exception on bad torrent URL Jan 21, 2025
@qstokkink qstokkink merged commit f2c7e4b into Tribler:main Jan 21, 2025
7 checks passed
@qstokkink qstokkink deleted the fix_tinfo_http_bdecode branch January 21, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

torrentinfo_endpoint.get_torrent_info bdecode RuntimeError
2 participants
@qstokkink @egbertbouman