Skip to content

Commit

Permalink
[refactor] 삭제 요청시 Dto 대신 form-data 형식으로 변경 & url을 imageUrl로 일괄 수정
Browse files Browse the repository at this point in the history
S3DeleteRequestDto 삭제. 컨트롤러에서 삭제 요구 url 데이터를 @RequestBody에서 @RequestParam으로 변경함.
  • Loading branch information
meena2003 committed Jan 7, 2024
1 parent f3a197f commit 4477997
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 15 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.haejwo.tripcometrue.global.s3.controller;

import com.haejwo.tripcometrue.global.s3.request.S3DeleteRequestDto;
import com.haejwo.tripcometrue.global.s3.response.S3UploadResponseDto;
import com.haejwo.tripcometrue.global.s3.service.S3Service;
import com.haejwo.tripcometrue.global.util.ResponseDTO;
Expand All @@ -27,8 +26,8 @@ public ResponseEntity<ResponseDTO<S3UploadResponseDto>> uploadImage(
}

@DeleteMapping("/v1/images")
public ResponseEntity<ResponseDTO> deleteImage(@RequestBody S3DeleteRequestDto requestDto) {
s3Service.removeImage(requestDto.url());
public ResponseEntity<ResponseDTO> deleteImage(@RequestParam("imageUrl") String imageUrl) {
s3Service.removeImage(imageUrl);
ResponseDTO<Void> responseDTO = ResponseDTO.ok();
return ResponseEntity.status(responseDTO.getCode()).body(responseDTO);
}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package com.haejwo.tripcometrue.global.s3.response;

public record S3UploadResponseDto(
String url
String imageUrl
) {
public S3UploadResponseDto(String url) {
this.url = url;
public S3UploadResponseDto(String imageUrl) {
this.imageUrl = imageUrl;
}
}

0 comments on commit 4477997

Please sign in to comment.