pad octet array to the left to avoid weirdness with values >= 2^23 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed there was some weirdness with snmpwalk when I tried to set Counter64 to values greater than or equal to 8388608 (aka 8mb aka 2^23):
.1.3.6.1.2.1.31.1.1.1.6.1 = Counter64: 18374967954639945728
.1.3.6.1.2.1.31.1.1.1.6.2 = Counter64: 8388607
This seems to be caused by the uint64_t.prototype.toOctets method not padding the array:
toOctets: hi:0, lo: 8388608 -> 128,0,0
toOctets: hi:0, lo: 8388607 -> 127,255,255
Once I padded the array by prepending 0's, things look better:
.1.3.6.1.2.1.31.1.1.1.6.1 = Counter64: 8388608
.1.3.6.1.2.1.31.1.1.1.6.2 = Counter64: 8388607
The change is very small: while (a.length<8) a.unshift(0);