Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numaan formoli/general components #41

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

NumaanFormoli
Copy link

Tracking Info

Resolves #13

Changes

  • I utilized TSE Constellation to create a guide for using buttons, text fields, checkboxes, and radio buttons.
  • I also created a custom larger text field component called TextArea to allow for larger input fields.

Testing

  • I created a test page that includes all the components to ensure they function correctly.
  • However, I encountered some issues:
    • TSE Constellation does not allow an error icon for incorrect text field inputs—only an error message can be displayed.
    • When reloading the website, text fields, checkboxes, and radio buttons initially appear black until they are clicked or interacted with.
    • The checkbox and radio button SVGs are slightly misaligned, causing a visual shift when clicked. However, the issue disappears once you click away from the component.
    • I believe these might be issues with TSE constellation, so I wanted to check with Ben. I'm creating this pull request because the basic functionality of the components are done.

Confirmation of Change

Screenshot 2025-01-29 at 12 55 19 PM Screenshot 2025-01-29 at 12 55 55 PM Screenshot 2025-01-29 at 12 56 16 PM

@NumaanFormoli NumaanFormoli requested a review from mraysu as a code owner January 29, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[COMPONENT] General Components
2 participants