Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from EmailJS to Nodemailer #90

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

wllmwu
Copy link
Member

@wllmwu wllmwu commented Apr 14, 2022

Administrative Info

[GitHub Issue #]
Make sure your branch name conforms to: <feature/staging/hotfix/...>/[username]/[3-4 word description separated by dashes]. Otherwise, please rename your branch and create a new PR.

Changes

What changes did you make?

  • Install nodemailer in root, remove emailjs-com from client
  • Add new API routes:
    • POST /email/registerOrg - send an email to the admin email address to notify about new org signup
    • POST /email/addUser - send an email to the newly added user containing a password reset link
  • Call those routes from the frontend upon successfully registering org/adding user
  • Closes Frontend: Switch from EmailJS to NodeMailer for automatic emails #72

Testing

How did you confirm your changes worked?

  • Tested registering an org and adding a user - received emails correctly in both cases

Confirmation of Change

Upload a screenshot, if possible. Otherwise, please provide instructions on how to see the change.

  • Register a new org and sign in to the [email protected] email account to see the first type of email
  • Add a new user with your email address in the [email protected] account (in Moneta) to see the second type of email
    Screen Shot 2022-04-22 at 15 03 32
    Screen Shot 2022-04-22 at 15 03 10

@wllmwu wllmwu requested a review from a team April 14, 2022 05:16
@wllmwu
Copy link
Member Author

wllmwu commented Apr 14, 2022

Notes @navidboloorian

If you think either of these should change, let me know and I'll address them!

@navidboloorian navidboloorian self-requested a review April 19, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: Switch from EmailJS to NodeMailer for automatic emails
2 participants