Skip to content

Commit

Permalink
fixes #74 - dead links to G-2150 and coding-style
Browse files Browse the repository at this point in the history
  • Loading branch information
PhilippSalvisberg committed Sep 21, 2019
1 parent b8df7f6 commit 5003d80
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/1-introduction/introduction.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ There are basically two types of standards.

1. Non-controversial

These standards make sense. There is no reason not to follow them. An example of this category is [G-2150](../4-language-usage/2-variables-and-types/1-general/g-2150): Avoid comparisons with NULL value, consider using IS [NOT] NULL.
These standards make sense. There is no reason not to follow them. An example of this category is [G-2150](../../4-language-usage/2-variables-and-types/1-general/g-2150): Avoid comparisons with NULL value, consider using IS [NOT] NULL.

2. Controversial

Almost every rule/guildeline falls into this category. An example of this category is [3 space indention](../3-coding-style/coding-style/#rules). - Why not 2 or 4 or even 8? Why not use tabs? You can argue in favor of all these options. In most cases it does not really matter which option you choose. Being consistent is more important. In this case it will make the code easier to read.
Almost every rule/guildeline falls into this category. An example of this category is [3 space indention](../../3-coding-style/coding-style/#rules). - Why not 2 or 4 or even 8? Why not use tabs? You can argue in favor of all these options. In most cases it does not really matter which option you choose. Being consistent is more important. In this case it will make the code easier to read.

For very controversial rules, we have started to include the reasoning either as a footnote or directly in the text.

Expand Down
4 changes: 2 additions & 2 deletions tools/run-in-container/genpdf.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ function write_file(){
FILE=$1
echo "" >> ${TARGET_DIR}/docs/index.md
sed -e 's/..\/image/image/g' ${DATA_DIR}/docs/${FILE} | \
sed -e 's|../4-language-usage/2-variables-and-types/1-general/g-2150|#g-2150-avoid-comparisons-with-null-value-consider-using-is-not-null|g' | \
sed -e 's|../3-coding-style/coding-style/#rules|#rules|g' | \
sed -e 's|../../4-language-usage/2-variables-and-types/1-general/g-2150|#g-2150-avoid-comparisons-with-null-value-consider-using-is-not-null|g' | \
sed -e 's|../../3-coding-style/coding-style/#rules|#rules|g' | \
sed -e 's|PLSQL-and-SQL-Coding-Guidelines.pdf||g' | \
sed -e 's/✘/X/g' >> ${TARGET_DIR}/docs/index.md
}
Expand Down

0 comments on commit 5003d80

Please sign in to comment.