Refacto: separate storage backend, merge client_interface and trow_server into "registry" #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoimbee
force-pushed
the
aw/separate-storage-backend
branch
from
2f86b03 to
8c87ce8
Compare
|
I want to get this over with, I will fix the OCI compliance tests later |
awoimbee
force-pushed
the
aw/separate-storage-backend
branch
from
91732c2 to
41bfc04
Compare
|
Yeah go for it. I don't really have time to review atm unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on this for a while...
Initial goal: separate all storage operations from trow_server so features such as tiered storage and s3 backend could be added later.
Final state:
storage.rstrow_serverandregistry_interfaceare united asregistryI think the next step is to add a database, working around the "manifest_history" files is not straightforward.
This PR breaks compatibility with the
datadirs of old trow versions.