quick fix for var name change

TsaiLintung · Aug 2, 2024 · 9de9a95 · 9de9a95
1 parent 30fe214
commit 9de9a95
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 1 deletion.
diff --git a/R/fastdid.R b/R/fastdid.R
@@ -85,9 +85,11 @@ fastdid <- function(data,
   validate_argument(dt, p)
 
   # validate and throw away not legal data 
+
   setnames(dt, c(timevar, cohortvar, unitvar), c("time", "G", "unit"))
   dt <- validate_dt(dt, p)
 
+
   # preprocess -----------------------------------------------------------
 
   #make dt conform to the WLOG assumptions of fastdid

diff --git a/R/validate.R b/R/validate.R
@@ -53,6 +53,7 @@ validate_argument <- function(dt, p){
 validate_dt <- function(dt, p){
 
   varnames <- unlist(p[str_ends(names(p), "var")], recursive = TRUE) #get all the argument that ends with "var"
+  varnames <- varnames[!varnames %in% c(p$timevar, p$unitvar, p$cohortvar)]
 
   raw_unit_size <- dt[, uniqueN(unit)]
   raw_time_size <- dt[, uniqueN(time)]

diff --git a/development/did.R b/development/did.R
@@ -1,13 +1,14 @@
 library(did)
+library(fastdid)
 
 rm(list = ls());gc()
 
 data(mpdta)
 mpdta$x <- rnorm(nrow(mpdta))
 
 #the unbalanced panel OR influence function calculation (DRDID::drdid_rc.R, 230, should be post - pre - or), since control function is subtracted
-#simultaneous valid band, should subset t>g  before getting the new critical value? (compute.aggte 376-383)
 
+# did ---------
 
 # repeated cross section with 
 out <- att_gt(yname="lemp",
@@ -46,3 +47,9 @@ for(est in c("dr", "ipw", "reg")){
     rm(out, agg)
   }
 }
+
+# fastdid ------------
+mpdta <- as.data.table(mpdta)
+setnames(mpdta, "first.treat", "firsttreat")
+result <- fastdid(mpdta, timevar = "year", cohortvar = "firsttreat", unitvar = "countyreal",outcomevar = "lemp",  result_type = "simple",
+                  allow_unbalance_panel = FALSE, covariatesvar = "x")
diff --git a/inst/tinytest/test_1_fastdid.R b/inst/tinytest/test_1_fastdid.R
@@ -45,6 +45,11 @@ expect_silent(fastdid(dt[G != 3], timevar = "time", cohortvar = "G", unitvar = "
 expect_silent(fastdid(dt, timevar = "time", cohortvar = "G", unitvar = "unit",outcomevar = "y",  result_type = "group_time", alpha = 0.01),
               info = "alternative alpha")
 
+dt2 <- copy(dt)
+setnames(dt2, c("time", "G", "unit"), c("t", "g", "u"))
+expect_silent(fastdid(dt2, timevar = "t", cohortvar = "g", unitvar = "u",outcomevar = "y",  result_type = "group_time", alpha = 0.01),
+              info = "other column names")
+
 # bootstrap part ------------------------
 
 expect_silent(fastdid(dt, timevar = "time", cohortvar = "G", unitvar = "unit",outcomevar = "y",  result_type = "group_time",