Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Default parameter addition check #384

Merged

Conversation

Jonathan-Rosenberg
Copy link
Contributor

Check that the traversed parameter was indeed added.
Fix tests.
Related to this comment.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #384 (a063c63) into main (2eb2513) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   81.67%   81.67%           
=======================================
  Files         195      195           
  Lines       10631    10632    +1     
=======================================
+ Hits         8683     8684    +1     
  Misses       1651     1651           
  Partials      297      297           
Flag Coverage Δ
unittests 81.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...er/check-new-request-non-path-default-parameter.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@reuvenharrison reuvenharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks for not trusting me :-)

@reuvenharrison reuvenharrison merged commit bdb2a75 into Tufin:main Sep 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants