Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: merge function #409

Merged
merged 12 commits into from
Nov 8, 2023
Merged

refactor: merge function #409

merged 12 commits into from
Nov 8, 2023

Conversation

tcdsv
Copy link
Collaborator

@tcdsv tcdsv commented Oct 30, 2023

  • move all calls to the merge function out of flattenSchemas function for cleaner code organization
  • use MergeSpec in validation testing
  • add state for future handling of circular refs

@tcdsv tcdsv marked this pull request as ready for review October 30, 2023 19:53
@reuvenharrison reuvenharrison merged commit 085753d into Tufin:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcdsv @reuvenharrison