Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check new required props for default value #551

Conversation

reuvenharrison
Copy link
Collaborator

@reuvenharrison reuvenharrison commented May 28, 2024

Added two new checks, for required request properties that have a default value:

  • request-property-became-required-with-default
  • new-required-request-property-with-default

See also #555

@reuvenharrison reuvenharrison linked an issue May 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.04%. Comparing base (4e41d1d) to head (db1cfcb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   83.85%   84.04%   +0.19%     
==========================================
  Files         227      227              
  Lines       13016    13012       -4     
==========================================
+ Hits        10914    10936      +22     
+ Misses       1687     1666      -21     
+ Partials      415      410       -5     
Flag Coverage Δ
unittests 84.04% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuvenharrison reuvenharrison merged commit 7d9a529 into main Jun 5, 2024
16 checks passed
@reuvenharrison reuvenharrison deleted the 549-incorrect-detection-of-breaking-change-for-default-values branch June 5, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Detection of Breaking Change for Default Values
2 participants