Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autolabeler 2 #1870

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Update autolabeler 2 #1870

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cf68ceb
Increase pcregrep buffer size
GarboMuffin Jan 13, 2025
49e733a
Print the diff
GarboMuffin Jan 13, 2025
eebd54f
Add more printing
GarboMuffin Jan 13, 2025
bf641aa
Unhardcode repo
GarboMuffin Jan 13, 2025
2f84ea1
Avoid unnecessary use of cat
GarboMuffin Jan 13, 2025
555fa97
update string
GarboMuffin Jan 13, 2025
68de451
update the other logs
GarboMuffin Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions .github/workflows/label.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
label-pull-request:
runs-on: ubuntu-latest

# This workflow is not useful to forks without significantly updating the workflow script.
# Disabled by default for forks since this is probably not useful.
if: ${{ github.repository == 'TurboWarp/extensions' }}

permissions:
Expand All @@ -34,21 +34,27 @@ jobs:
got_any_specific_label=false

if [[ "$BASE_REF" == "master" ]]; then
echo "Downloading pull request diff"

# Download just the diff so it is harder to accidentally run any code from the pull request.
gh pr diff --repo TurboWarp/extensions "$PR_NUMBER" > pr.diff
gh pr diff --repo "$GH_REPO" "$PR_NUMBER" | tee pr.diff

# Note that pcregrep exits with success on any match, failure on no match
if pcregrep -M "^--- /dev/null\n\+\+\+ b/extensions/" pr.diff; then
# Note that pcregrep exits with success on any match, failure on no match or internal buffer overflow.
# To avoid errors on big diffs like compressed SVGs, increase the internal buffer size dramatically.
# This is pretty big and uses ~50MB of RAM but the machines can fit that just fine.
if pcregrep --buffer-size 16777216 -M "^--- /dev/null\n\+\+\+ b/extensions/" pr.diff; then
# Example:
# --- /dev/null
# +++ b/extensions/DangoCat/extension.js
gh pr edit --repo TurboWarp/extensions "$PR_NUMBER" --add-label "$LABEL_NEW_EXTENSION"
echo "Adding label: $LABEL_NEW_EXTENSION"
gh pr edit --repo "$GH_REPO" "$PR_NUMBER" --add-label "$LABEL_NEW_EXTENSION"
got_any_specific_label=true
elif pcregrep "^\+\+\+ b/extensions/" pr.diff; then
elif pcregrep --buffer-size 16777216 "^\+\+\+ b/extensions/" pr.diff; then
# Example:
# --- a/extensions/DangoCat/extension.js
# +++ b/extensions/DangoCat/extension.js
gh pr edit --repo TurboWarp/extensions "$PR_NUMBER" --add-label "$LABEL_CHANGE_EXTENSION"
echo "Adding label: $LABEL_CHANGE_EXTENSION"
gh pr edit --repo "$GH_REPO" "$PR_NUMBER" --add-label "$LABEL_CHANGE_EXTENSION"
got_any_specific_label=true
fi
else
Expand All @@ -57,9 +63,11 @@ jobs:

# Any PR that didn't get a specific label will go into other, for a human to look at.
if [[ "$got_any_specific_label" == "false" ]]; then
gh pr edit --repo TurboWarp/extensions "$PR_NUMBER" --add-label "$LABEL_OTHER"
echo "Adding label: $LABEL_OTHER"
gh pr edit --repo "$GH_REPO" "$PR_NUMBER" --add-label "$LABEL_OTHER"
fi
env:
PR_NUMBER: "${{ github.event.number }}"
BASE_REF: "${{ github.base_ref }}"
GH_TOKEN: "${{ github.token }}"
GH_REPO: "${{ github.repository }}"
Loading