Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JeremyGamer13/tween: Fix Pause button not suspending Tweening #1887

Merged
merged 4 commits into from
Feb 1, 2025

Conversation

fath11
Copy link
Contributor

@fath11 fath11 commented Jan 25, 2025

Resolving #1787

@github-actions github-actions bot added the pr: change existing extension Pull requests that change an existing extension label Jan 25, 2025
@SharkPool-SP SharkPool-SP changed the title JeremyGamer13/tween: Pause button now effect Tween JeremyGamer13/tween: Fix Pause button not suspending Tweening Jan 25, 2025
@CST1229
Copy link
Collaborator

CST1229 commented Jan 25, 2025

wouldn't this break when using the reset timer block?

Copy link
Member

@GarboMuffin GarboMuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it would

@SharkPool-SP
Copy link
Collaborator

wouldn't this break when using the reset timer block?

didnt think of that.

@GarboMuffin
Copy link
Member

There's also the edge case where the tweening block can be started while the project is already paused, in which case it should play as if the project were not paused

So this is probably going to be a good bit more complicated

It's 1:30AM so you probably don't want me to suggest something right now

@SharkPool-SP
Copy link
Collaborator

Its 11:30pm for me rn, best I can think of is set up our own timer for tween that iterates using before execute and pauses when runtime is paused.

@CST1229
Copy link
Collaborator

CST1229 commented Jan 25, 2025

Its 11:30pm for me rn, best I can think of is set up our own timer for tween that iterates using before execute and pauses when runtime is paused.

yea, that is also exactly how the glide block works (actually not exactly because the glide block iterates using yielding. maybe we could look at that for inspiration.)

@fath11
Copy link
Contributor Author

fath11 commented Jan 25, 2025

since the glide block doesn't have all those issues its prob best to just copy it which shouldn't be hard

i will push the fix tomorrow

@SharkPool-SP
Copy link
Collaborator

since the glide block doesn't have all those issues its prob best to just copy it which shouldn't be hard

i will push the fix tomorrow

It's been tomorrow

@fath11
Copy link
Contributor Author

fath11 commented Jan 27, 2025

ive been a little busy but i should be free today

@DNin01 DNin01 linked an issue Jan 27, 2025 that may be closed by this pull request
@CubesterYT
Copy link
Member

!format

@CubesterYT CubesterYT merged commit e2016e9 into TurboWarp:master Feb 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: change existing extension Pull requests that change an existing extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pause button doesn't affect Tween for whatever reason
6 participants