-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JeremyGamer13/tween: Fix Pause button not suspending Tweening #1887
Conversation
wouldn't this break when using the reset timer block? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it would
didnt think of that. |
There's also the edge case where the tweening block can be started while the project is already paused, in which case it should play as if the project were not paused So this is probably going to be a good bit more complicated It's 1:30AM so you probably don't want me to suggest something right now |
Its 11:30pm for me rn, best I can think of is set up our own timer for tween that iterates using before execute and pauses when runtime is paused. |
yea, that is also exactly how the glide block works (actually not exactly because the glide block iterates using yielding. maybe we could look at that for inspiration.) |
since the glide block doesn't have all those issues its prob best to just copy it which shouldn't be hard i will push the fix tomorrow |
It's been tomorrow |
ive been a little busy but i should be free today |
!format |
Resolving #1787