Lily/MoreTimers: Don't rely on system clock #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNin01
added
the
pr: change existing extension
|
!format |
|
I think we can still do better — Scratch's timer uses a VM interface which only updates between frames. In More Timers, if a script takes a long time to execute (e.g., a long run-without-screen-refresh loop) the values of the timers could change during execution, which works differently than Scratch's. However, fixing this parity issue might require breaking changes. |
|
Maybe we could look into stack timer? |
|
Stack timer great for within a block but the timers outlive each individual block here |
|
Wouldn't be opposed to removing the Math.floor() |
GarboMuffin
approved these changes
Feb 1, 2025
CubesterYT
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the More Timers extension from being thrown off by system clock changes.
Tested, no breaking changes.