Add DynamicPPL integration tests #2393
Open
+865
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
commented
Nov 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
=======================================
Coverage 86.41% 86.41%
=======================================
Files 22 22
Lines 1575 1575
=======================================
Hits 1361 1361
Misses 214 214 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12054932691Details
💛 - Coveralls |
penelopeysm
force-pushed
the
py/add-dppl-tests
branch
from
9f8023c
to
1412416
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @test all(x -> DynamicPPL.istrans(vi, x), meta.vns) | ||
| DynamicPPL.invlink!!(vi, spl, model) | ||
| @test all(x -> !DynamicPPL.istrans(vi, x), meta.vns) | ||
| @test meta.vals ≈ v atol=1e-10 |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test meta.vals ≈ v atol=1e-10 | |
| @test meta.vals ≈ v atol = 1e-10 |
Comment on lines
+77
to
+78
| @test meta.s.vals ≈ v_s atol=1e-10 | ||
| @test meta.m.vals ≈ v_m atol=1e-10 |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test meta.s.vals ≈ v_s atol=1e-10 | |
| @test meta.m.vals ≈ v_m atol=1e-10 | |
| @test meta.s.vals ≈ v_s atol = 1e-10 | |
| @test meta.m.vals ≈ v_m atol = 1e-10 |
Comment on lines
+88
to
+89
| @test meta.s.vals ≈ v_s atol=1e-10 | ||
| @test meta.m.vals ≈ v_m atol=1e-10 |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test meta.s.vals ≈ v_s atol=1e-10 | |
| @test meta.m.vals ≈ v_m atol=1e-10 | |
| @test meta.s.vals ≈ v_s atol = 1e-10 | |
| @test meta.m.vals ≈ v_m atol = 1e-10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Turing/DynamicPPL integration tests (from the
test/turingfolder in DynamicPPL) to this repository instead.The main motivation behind this PR is to ensure that the tests added here are always run whenever a new version of Turing is released, thus making it impossible to release a version of Turing that contains a buggy version of DynamicPPL. See TuringLang/DynamicPPL.jl#703 for more thorough explanation.
Some implementation details:
link!(vi, sampler)->link!!(vi, sampler, model); the same withinvlink!; andAutoReverseDiff(false)->AutoReverseDiff(; compile=false)).Otherwise, this is a straight copy paste.