-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better performance (especially on large files). #9
Open
aeh
wants to merge
53
commits into
Turistforeningen:master
Choose a base branch
from
noblesamurai:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the image exif data returned width and hight properties will be reversed to match the image's real orientation. **Usage:** ``` metadata(path, {autoOrient: true}, function(error, data) { console.log(error); console.log(data); }); ```
Uncaught Error: identify: unknown image property "%[name]" @ warning/property.c/InterpretImageProperties/3600.
Return image size in bytes
…er-update-all Update all dependencies 🌴
npm: ignore assets dir
adding github actions
Add tartufo pre-commit hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dealing with large images (especially SVG images with a large viewport) can take a long time and use an excessive amount of memory or even die with a resources exhausted error.
Using this test file:
Using the
time
function and thememusg
function found here: https://gist.github.com/netj/526585This alternative implementation uses ImageMagick's
convert -ping
function which doesn't keep any pixel information.Significantly better.
I needed to change
%[size]
to%b
since%[size]
returns0
in the-ping
version. Reading the docs I'd expect both options to be the same however that isn't quite the case in practice.identify
will return 215B for both%b
and%[size]
. It also states that it is anMVG
file so maybe it is converting it first and 215B is the size of the converted file?identify -format "%b" test.svg
it will return 180B as does the aboveconvert -ping
call. Usingls
also returns 180B so I'd argue this is the correct number. I'm not exactly sure where the other 35B are coming from in the other case.I've also added the
-precision 12
option. There were some failing tests on my local OSX box since it seems the default precision for OSX is 6 while Linux is 4. Setting it to 12 removes that difference and also gives better accuracy.