Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ryhmittele ohjelmakartan päivät viiden ryhmiin #76

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

kovipu
Copy link
Member

@kovipu kovipu commented Apr 10, 2024

Päätin sitten poistaa ton yli-insinööröidyn weekkey himmelin. En rikonnut mitään ainakin nopean testailun perusteella, mutta en testannut tota archiveria.

@kovipu kovipu requested a review from niemisami April 10, 2024 19:35
const groupIdx = Math.floor(idx / GROUP_SIZE);
acc[groupIdx] = append(date, acc[groupIdx] ?? []);
return acc;
}, []);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tämä grouppaushärveli voisi ehkä olla nätimpi Ramdan groupBy-funkkarin avulla. Se funkkari ei kuitenkaan anna suoraan indexiä, joten pitäisi käsin lisätä eka indexit. Sanoisin että good enough 😄

Mitä tuumaatte?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tolla saa indexin, testaan

@niemisami
Copy link
Contributor

Pistäks jonkun screenshotin miten pelittää

Copy link
Contributor

@niemisami niemisami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Täähän on hyvä 👌

@kovipu kovipu merged commit ab330ea into develop Apr 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants