Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Teeman vaihto #89

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

niemisami
Copy link
Contributor

@niemisami niemisami commented Oct 23, 2024

Teeman vaihtaminen tailwind.config.js filussa const isSyssyColors = true | false.

Koitin parhaani mukaan yhdistellä ja kategorioida nettisivun värit, jotta ei tarvis aina revertellä vanhoja koodeja ja unohdella koodiin hassuja värejä 😁

Tehty #88 päälle ja tein parhaani #58 tän pärrän avulla

@niemisami niemisami force-pushed the chore/simpler-theme-color-swap branch from dac1df7 to f94af91 Compare October 23, 2024 20:41
@niemisami
Copy link
Contributor Author

niemisami commented Oct 23, 2024

Tässä vielä miltä etusivu näyttää, jos kaikki komponentit olis käynnissä

  1. wapputeema vanha
    syssyteema-uusi

  2. wapputeema uusi
    wapputeema-vanha

  3. syssyteema uusi
    wapputeema-uusi

@niemisami niemisami force-pushed the chore/simpler-theme-color-swap branch from f94af91 to b2153ce Compare October 23, 2024 20:49
@niemisami niemisami changed the base branch from feat/syssy-2024 to develop October 23, 2024 20:53
@niemisami niemisami force-pushed the chore/simpler-theme-color-swap branch from b2153ce to fbf3060 Compare October 23, 2024 20:54
Copy link
Member

@kovipu kovipu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super homma että jaksoit tehdä tän 👏

Ainoa muutostoive on, että ton syssyteeman footeri ei kontrastaa sponssipalkista, laittaisin footerille tummemman taustan. (Näin uskoisin olleen aikasemmin?)

Lisäksi vielä tuo off-season normikontsa ei tarvitse olla etusivulla kun ohjelmakartta on näkyvissä, mutta se on ehkä ton toisen vetarin tontilla?

Comment on lines 152 to 182
{[
{
message: 'hei',
name: 'sami',
timestamp: +new Date(),
source: null,
},
{
message: 'hei',
name: 'sami',
timestamp: +new Date(),
source: null,
},
{
message: 'hei',
name: 'sami',
timestamp: +new Date(),
source: 'telegram',
},
{
message: 'hei',
name: 'sami',
timestamp: +new Date(),
source: null,
},
{
message: 'hei',
name: 'sami',
timestamp: +new Date(),
source: null,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vahingossa jäänyt mock-dataa?

Comment on lines +21 to +48
radio: isSyssyColors
? // Syssy
{
common: '#9b3970',
controller: '#58265d',
bg: '#230127',
bg200: '#58265d',
action: '#db8841',
accent: '#db8841',
accent200: '#eef2b0',
secondary: '#9b3970',
promote: '#9b3970',
night: '#58265d',
}
: // Wappu
{
common: '#001C36',
controller: '#000e1c',
bg: '#001C36',
bg200: '#001831',
action: '#5bbfbf',
accent: '#F65F52',
accent200: '#F65F52',
secondary: '#5bbfbf',
header: '#F65F52',
promote: '#5bbfbf',
night: '#60A3EE',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tosi hyvä! 👏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ei oo täysin loppuun mietittyjä kaikki nimet, mutta sai nyt vietyä eteenpäin 😁 Joku kuitenkin tekee saitin nollista kohta 😁

@niemisami niemisami changed the base branch from develop to feat/syssy-2024 October 24, 2024 08:23
@niemisami niemisami merged commit 986f0e9 into feat/syssy-2024 Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants