fix(tests): move password validation to the top

this should fix the occasionally failed tests
Tutortoise · Nov 22, 2024 · e5ff17d · e5ff17d
1 parent 9ef2720
commit e5ff17d
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 32 deletions.
diff --git a/tests/integration/learner.test.ts b/tests/integration/learner.test.ts
@@ -138,6 +138,22 @@ describe("Update learner password", async () => {
     idToken = token;
   });
 
+  test("should validate password", async () => {
+    const res = await supertest(app)
+      .put("/api/v1/learners/password")
+      .set("Authorization", `Bearer ${idToken}`)
+      .send({
+        currentPassword: "1234",
+        newPassword: "123",
+        confirmPassword: "123",
+      })
+      .expect(400);
+
+    expect(res.body.errors[0].message).toEqual(
+      "Password must be at least 8 characters",
+    );
+  });
+
   test("should be able to update learner password", async () => {
     const newPassword = faker.internet.password();
     await supertest(app)
@@ -162,20 +178,4 @@ describe("Update learner password", async () => {
       })
       .expect(401);
   });
-
-  test("should validate password", async () => {
-    const res = await supertest(app)
-      .put("/api/v1/learners/password")
-      .set("Authorization", `Bearer ${idToken}`)
-      .send({
-        currentPassword: "1234",
-        newPassword: "123",
-        confirmPassword: "123",
-      })
-      .expect(400);
-
-    expect(res.body.errors[0].message).toEqual(
-      "Password must be at least 8 characters",
-    );
-  });
 });
diff --git a/tests/integration/tutor.test.ts b/tests/integration/tutor.test.ts
@@ -129,6 +129,22 @@ describe("Update tutor password", async () => {
     idToken = token;
   });
 
+  test("should validate password", async () => {
+    const res = await supertest(app)
+      .put("/api/v1/tutors/password")
+      .set("Authorization", `Bearer ${idToken}`)
+      .send({
+        currentPassword: "1234",
+        newPassword: "123",
+        confirmPassword: "123",
+      })
+      .expect(400);
+
+    expect(res.body.errors[0].message).toEqual(
+      "Password must be at least 8 characters",
+    );
+  });
+
   test("should be able to update tutor password", async () => {
     const newPassword = faker.internet.password();
     await supertest(app)
@@ -153,20 +169,4 @@ describe("Update tutor password", async () => {
       })
       .expect(401);
   });
-
-  test("should validate password", async () => {
-    const res = await supertest(app)
-      .put("/api/v1/tutors/password")
-      .set("Authorization", `Bearer ${idToken}`)
-      .send({
-        currentPassword: "1234",
-        newPassword: "123",
-        confirmPassword: "123",
-      })
-      .expect(400);
-
-    expect(res.body.errors[0].message).toEqual(
-      "Password must be at least 8 characters",
-    );
-  });
 });