Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: setup unit and integration testing #3

Merged
merged 12 commits into from
Nov 17, 2024
Merged

test: setup unit and integration testing #3

merged 12 commits into from
Nov 17, 2024

Conversation

Veirt
Copy link
Member

@Veirt Veirt commented Nov 15, 2024

ini ngakalin banget apa cocok aja begini

@Veirt Veirt assigned Famozzy and elskow and unassigned Famozzy Nov 15, 2024
@Famozzy
Copy link
Member

Famozzy commented Nov 16, 2024

udah cocok kok

elskow
elskow reviewed Nov 16, 2024
View reviewed changes
Copy link
Member

@elskow elskow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think no, krna dia kan ujung ujungnya harus connect ke firebasenya krna gapake mocking firebasenya kan? ujung ujungnya ntar pas ci ngeseed unused datas atau bisa put extra effort buat nambahin remove data tiap abis testing. Menurutku,lain kali aja

@Veirt
Copy link
Member Author

Veirt commented Nov 16, 2024

kalo misal di set up firebase local emulator gmn?

@elskow
Copy link
Member

elskow commented Nov 16, 2024

kalo misal di set up firebase local emulator gmn?

boleh, tapi setup firebase.json ama setup ci nya dulu buat sekarang, jangan langsung merge. Sekalian reconsider kemungkinan ci-nya bakalan lama atau ngga. Terus mungkin bagian config jangan lupa diconfigure lagi. Soalnya kan dia raise error, bisa aja sih generate envnya waktu bikin workflow/pipelinenya. Atau mungkin best waynya kasi condition pas jalan testing, dia bakalan pake firebase emu

@Veirt Veirt force-pushed the test/setup-integration-testing branch 2 times, most recently from 6f0cd84 to 005516d Compare November 16, 2024 20:22
@Veirt
Copy link
Member Author

Veirt commented Nov 16, 2024

sedih amat, pake act gabisa sumpah. makanya aku test disini

@Veirt Veirt force-pushed the test/setup-integration-testing branch from 005516d to 8acda7c Compare November 16, 2024 20:27
@elskow elskow self-requested a review November 17, 2024 12:15
elskow
elskow approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@elskow elskow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 menit masih reasonable lah ya

@Veirt Veirt changed the title test: setup integration testing with vitest and supertest test: setup unit and integration testing Nov 17, 2024
@Veirt Veirt merged commit 545f777 into master Nov 17, 2024
1 check passed
@Veirt Veirt deleted the test/setup-integration-testing branch November 23, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elskow elskow elskow approved these changes

Assignees

@elskow elskow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Veirt @Famozzy @elskow