This repository has been archived by the owner on Oct 26, 2023. It is now read-only.
Fix styling of sessions in hallway and exhibition #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mklaehn
suggested changes
Oct 2, 2023
cinema/build.gradle
Outdated
| // jvmArgs '-Dorg.tweetwallfx.scheduledata.day=friday' | ||
| // jvmArgs '-Dorg.tweetwallfx.scheduledata.time=10:00Z' | ||
| // jvmArgs '-Dorg.tweetwallfx.conference.randomRatedTalks=true' | ||
| jvmArgs '-Dorg.tweetwallfx.scheduledata.day=thursday' |
| @@ -2,6 +2,7 @@ | |||
| "conferenceClient": { | |||
| "eventBaseUri": "https://dvbe23.cfp.dev/api/public", | |||
| "votingResultsUri": "https://us-central1-voxxrin-v3.cloudfunctions.net/publicEventStats", | |||
| "votingResultsToken": "eventStats:devoxx-voxxed:c5ac7b45-f7cb-4192-a0ee-f6f7596cad30", | |||
There was a problem hiding this comment.
Should no longer be necessary. Undo please
| @@ -112,6 +112,9 @@ | |||
| "nodeSelector": "#scheduleNode" | |||
| } | |||
| }, | |||
| { | |||
| "stepClassName": "org.tweetwallfx.conference.stepengine.steps.SpeakerImageMosaicStep" | |||
exhibition/build.gradle
Outdated
| @@ -29,8 +29,8 @@ application { | |||
| } | |||
|
|
|||
| tasks.withType(JavaExec).configureEach { | |||
| // jvmArgs '-Dorg.tweetwallfx.scheduledata.day=friday' | |||
| // jvmArgs '-Dorg.tweetwallfx.scheduledata.time=10:00Z' | |||
| jvmArgs '-Dorg.tweetwallfx.scheduledata.day=monday' | |||
hallway/build.gradle
Outdated
| @@ -29,8 +29,8 @@ application { | |||
| } | |||
|
|
|||
| tasks.withType(JavaExec).configureEach { | |||
| // jvmArgs '-Dorg.tweetwallfx.scheduledata.day=friday' | |||
| // jvmArgs '-Dorg.tweetwallfx.scheduledata.time=10:00Z' | |||
| jvmArgs '-Dorg.tweetwallfx.scheduledata.day=monday' | |||
Also spotless is complaining |
svenreimers
force-pushed
the
bugfix/session-title-styling
branch
from
68caef8 to
db11b28
Compare
mklaehn
approved these changes
Oct 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.