Better encoding, currentColor
support and identifier escaping
#27
+100
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is batch of changes that was necessary for my SVG sprite tool.
currentColor
support:color
attribute. (https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/color).
character as part of identifier. This is perfectly valid in HTML/XML. As such, CSS supports such identifier as well, the special character just have to be escaped.ByteString
approach doesn't work properly (loading and storing) when SVG contains some multi-byte characters. This specifically applies to CSS escaping for identifiers, which would escape the multi-byte characters as separate characters instead of single one whenByteString
is used instead ofString
orText
.arc
a1.3 1.3 0 01-1.3-1.3
(yes, it's valid). You can see01
in the output which no a single number, but two flags. Current path parser failed on such path segment.