Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TT-1961: add support for multiple plugin bundles #126

Merged
merged 8 commits into from
Oct 21, 2024
Merged

TT-1961: add support for multiple plugin bundles #126

merged 8 commits into from
Oct 21, 2024

Conversation

imogenkraak
Copy link
Contributor

@imogenkraak imogenkraak commented Oct 15, 2024 •
edited
Loading

Description

Remove statement setting limit of one plugin file per bundle.

Related Issue

TT-1961

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules dependencies have been updated; run go mod tidy in applicable directories.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • golangci-lint run

@imogenkraak imogenkraak marked this pull request as ready for review October 15, 2024 08:54
@imogenkraak imogenkraak requested a review from a team as a code owner October 15, 2024 08:54
@imogenkraak imogenkraak requested review from umit and removed request for a team October 15, 2024 08:54
umit
umit reviewed Oct 15, 2024
View reviewed changes
bundles/simple/plugin-2.go Outdated Show resolved Hide resolved
umit
umit reviewed Oct 15, 2024
View reviewed changes
bundles/simple/plugin-2.go Outdated Show resolved Hide resolved
umit
umit approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@umit umit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imogenkraak imogenkraak requested a review from mitjaziv October 16, 2024 07:57
@mitjaziv mitjaziv changed the title TT-1961: support multiple plugins per bundle TT-1961: add support for multiple plugin bundle Oct 21, 2024
@mitjaziv mitjaziv force-pushed the TT-1961-multiple-plugins-per-bundle branch 2 times, most recently from 8d7019f to 808a998 Compare October 21, 2024 09:28
@mitjaziv mitjaziv force-pushed the TT-1961-multiple-plugins-per-bundle branch from 808a998 to 6657da6 Compare October 21, 2024 09:41
@mitjaziv mitjaziv changed the title TT-1961: add support for multiple plugin bundle TT-1961: add support for multiple plugin bundles Oct 21, 2024
@mitjaziv mitjaziv merged commit 9643c59 into master Oct 21, 2024
1 check passed
@mitjaziv mitjaziv deleted the TT-1961-multiple-plugins-per-bundle branch October 21, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitjaziv mitjaziv mitjaziv approved these changes

@umit umit umit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imogenkraak @umit @mitjaziv