Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TT-13350: bump go version to v1.22.8 #127

Merged
merged 1 commit into from
Oct 21, 2024
Merged

TT-13350: bump go version to v1.22.8 #127

merged 1 commit into from
Oct 21, 2024

Conversation

mitjaziv
Copy link
Collaborator

@mitjaziv mitjaziv commented Oct 21, 2024 •
edited
Loading

Description

Change bumps go version to v1.22.8.

Related Issue

TT-13350

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules dependencies have been updated; run go mod tidy in applicable directories.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • golangci-lint run

@mitjaziv mitjaziv requested a review from a team as a code owner October 21, 2024 10:14
@mitjaziv mitjaziv requested review from umit and removed request for a team October 21, 2024 10:14
@mitjaziv mitjaziv force-pushed the TT-13350-bump-golang branch from 3cf7913 to ba39a89 Compare October 21, 2024 10:20
umit
umit approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@umit umit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mitjaziv mitjaziv merged commit 31c7540 into master Oct 21, 2024
1 check passed
@mitjaziv mitjaziv deleted the TT-13350-bump-golang branch October 21, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umit umit umit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitjaziv @umit