Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10430: add bundle build setup #47

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

mitjaziv
Copy link
Collaborator

@mitjaziv mitjaziv commented Nov 13, 2023

Description

Change add setup to build sample go plugin bundle in the repository,
which will be used in the integration.

Related Issue

TT-10430

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor in applicable directories.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@mitjaziv mitjaziv marked this pull request as ready for review November 13, 2023 16:15
@mitjaziv mitjaziv requested a review from a team as a code owner November 13, 2023 16:15
@mitjaziv mitjaziv requested review from umit, olamilekan000 and komuw and removed request for a team November 13, 2023 16:15
@mitjaziv mitjaziv merged commit 570cdb3 into master Nov 13, 2023
1 check failed
@mitjaziv mitjaziv deleted the TT-10430-add-bundle-build branch November 13, 2023 19:27
mitjaziv added a commit that referenced this pull request Nov 13, 2023
Change add setup to build sample go plugin bundle in the repository,
which will be used in the integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants