Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-10798] Added support embedded TIB in dashboard and tyk-stack #212

Merged
merged 4 commits into from
Jan 18, 2024
Merged

[TT-10798] Added support embedded TIB in dashboard and tyk-stack #212

merged 4 commits into from
Jan 18, 2024

Conversation

komalsukhani
Copy link
Collaborator

@komalsukhani komalsukhani commented Jan 12, 2024 •
edited
Loading

Description

Added a field to enable/disable embedded TIB in the dashboard and tyk-stack chart

tib:
  enabled: false

Related Issue

https://tyktech.atlassian.net/browse/TT-10798

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@komalsukhani komalsukhani marked this pull request as ready for review January 12, 2024 11:02
@komalsukhani komalsukhani requested a review from a team as a code owner January 12, 2024 11:02
@komalsukhani komalsukhani requested review from olamilekan000 and removed request for a team January 12, 2024 11:02
@komalsukhani komalsukhani requested review from buraksekili and a team and removed request for olamilekan000 January 12, 2024 11:03
buraksekili
buraksekili reviewed Jan 12, 2024
View reviewed changes
@singhpr singhpr merged commit 04bccaa into main Jan 18, 2024
9 checks passed
@singhpr singhpr deleted the feat/TT-10798/embedded-tib branch January 18, 2024 09:36
buraksekili pushed a commit that referenced this pull request Jan 18, 2024
@komalsukhani @buraksekili
[TT-10798] Added support embedded TIB in dashboard and tyk-stack (#212)
a9bfca5 
* Add support embedded TIB in dashboard and tyk-stack

* Update readmes

* Update notes of values file
buraksekili pushed a commit that referenced this pull request Jan 18, 2024
@komalsukhani @buraksekili
[TT-10798] Added support embedded TIB in dashboard and tyk-stack (#212)
b2be6ec 
* Add support embedded TIB in dashboard and tyk-stack

* Update readmes

* Update notes of values file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraksekili buraksekili buraksekili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@komalsukhani @buraksekili @singhpr